Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): remove analytics API consent dependency #864

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ruifcnunes
Copy link
Contributor

Description

This PR removes the dependency of a marketing consent on the client-side Analytics API integration.

The consent must be managed on the server side, as it is already passed to its endpoint along with all event data. We must only control the consent there and load the server-side integrations accordingly.

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@ruifcnunes ruifcnunes added this to the dev-main-12-09-23 milestone Sep 12, 2023
@ruifcnunes ruifcnunes changed the base branch from main to dev-main-12-09-23 September 12, 2023 16:42
@github-actions github-actions bot added 📦 react Relative to the `@farfetch/blackout-react` package type: bug Something isn't working properly labels Sep 12, 2023
@talbertosilva talbertosilva merged commit 91b030e into dev-main-12-09-23 Sep 13, 2023
4 checks passed
@talbertosilva talbertosilva deleted the fix_analytics_api_should_load branch September 13, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 react Relative to the `@farfetch/blackout-react` package type: bug Something isn't working properly
Development

Successfully merging this pull request may close these issues.

3 participants