Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix social login actions #865

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jpklzm
Copy link
Contributor

@jpklzm jpklzm commented Sep 13, 2023

Description

This fixes socialLogin and createAccountLink actions that were missing user id. Also, it renames useSocialLogin action from login to socialLogin, in order to prevent issues with the usual login action.

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@github-actions github-actions bot added 📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package type: bug Something isn't working properly labels Sep 13, 2023
@ruifcnunes ruifcnunes merged commit 36b6979 into dev-main-12-09-23 Sep 13, 2023
4 checks passed
@ruifcnunes ruifcnunes deleted the fix_fix-social-login-actions branch September 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package type: bug Something isn't working properly
Development

Successfully merging this pull request may close these issues.

3 participants