Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics|react): update recommendations tracking parameters #874

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat(analytics|react): update recommendations tracking parameters #874

merged 1 commit into from
Oct 19, 2023

Conversation

talbertosilva
Copy link

Description

  • Updated recommendations tracking parameters (additions and naming changes)
  • Updated unit tests related to those same changes

Dependencies

None.

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@talbertosilva talbertosilva added type: feature New feature 📦 react Relative to the `@farfetch/blackout-react` package 📦 analytics Relative to the `@farfetch/blackout-analytics` package labels Oct 12, 2023
@talbertosilva talbertosilva added this to the dev-main-26-09-23 milestone Oct 12, 2023
@talbertosilva talbertosilva self-assigned this Oct 12, 2023
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Oct 12, 2023
@talbertosilva talbertosilva force-pushed the feat_update_recommendations_tracking_parameters_main branch from a2db1a1 to c655a3a Compare October 16, 2023 10:45
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Oct 16, 2023
@talbertosilva talbertosilva force-pushed the feat_update_recommendations_tracking_parameters_main branch from c655a3a to 3016f8b Compare October 18, 2023 08:51
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Oct 18, 2023
@talbertosilva talbertosilva force-pushed the feat_update_recommendations_tracking_parameters_main branch from 3016f8b to 0f21872 Compare October 18, 2023 09:45
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Oct 18, 2023
@danielbento92 danielbento92 merged commit 3ddac24 into dev-main-26-09-23 Oct 19, 2023
3 checks passed
@danielbento92 danielbento92 deleted the feat_update_recommendations_tracking_parameters_main branch October 19, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbento92 danielbento92 danielbento92 approved these changes

@boliveira boliveira boliveira approved these changes

@ruifcnunes ruifcnunes Awaiting requested review from ruifcnunes

Assignees

@talbertosilva talbertosilva

Labels
📦 analytics Relative to the `@farfetch/blackout-analytics` package 📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature
Milestone
dev-main-26-09-23
Development

Successfully merging this pull request may close these issues.
3 participants
@talbertosilva @boliveira @danielbento92