Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update forter script for v1 #876

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: update forter script for v1 #876

merged 1 commit into from
Oct 17, 2023

Conversation

danielbento92
Copy link
Contributor

Description

update forter script

Dependencies

None

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@danielbento92 danielbento92 added the type: feature New feature label Oct 13, 2023
@danielbento92 danielbento92 added this to the dev-v1-05-09-23 milestone Oct 13, 2023
@danielbento92 danielbento92 self-assigned this Oct 13, 2023
@github-actions github-actions bot added 📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature and removed type: feature New feature labels Oct 13, 2023
boliveira
boliveira reviewed Oct 16, 2023
View reviewed changes
packages/react/src/analytics/integrations/Forter/loadForterScriptForSiteId.js Outdated
@@ -1,230 +1,342 @@
/* Script info: used skd version from token published on 2023-10-03 */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Script info: used skd version from token published on 2023-10-03 */
/* Script info: used sdk version from Forter published on 2023-10-03 */

@danielbento92 danielbento92 force-pushed the feat_update_forter_script_v1 branch from 9f92f4f to 4dcc9c8 Compare October 16, 2023 08:30
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Oct 16, 2023
@danielbento92 danielbento92 merged commit a934326 into dev-v1-05-09-23 Oct 17, 2023
@danielbento92 danielbento92 deleted the feat_update_forter_script_v1 branch October 17, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boliveira boliveira boliveira approved these changes

@talbertosilva talbertosilva talbertosilva approved these changes

Assignees

@danielbento92 danielbento92

Labels
📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature
Milestone
dev-v1-05-09-23
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbento92 @boliveira @talbertosilva