Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: join relatedCommercedata with editorial data #974

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: join relatedCommercedata with editorial data #974

merged 1 commit into from
Jan 30, 2024

Conversation

edupaulos
Copy link
Contributor

Description

This PR includes changes to accept the customListingPages :

  • serverInitialState/listings -> search for content in the relatedCommerceData,
  • getSlug -> change to return the right slug,
  • useProductsListing -> add fetchCustomListingAction and adjust function to accept customListingPages,
  • Add respective factory.

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@github-actions github-actions bot added 📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package type: feature New feature labels Jan 23, 2024
@edupaulos edupaulos requested a review from danpadrinom January 23, 2024 17:45
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from 4d75e31 to 0355230 Compare January 23, 2024 17:49
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 23, 2024
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from 0355230 to a5a2422 Compare January 24, 2024 11:37
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 24, 2024
@edupaulos edupaulos self-assigned this Jan 24, 2024
@dnamorim dnamorim changed the base branch from main to dev-main-23-01-24 January 26, 2024 14:27
@dnamorim dnamorim added this to the dev-main-23-01-24 milestone Jan 26, 2024
@dnamorim dnamorim force-pushed the dev-main-23-01-24 branch 2 times, most recently from b13724c to 1729a08 Compare January 26, 2024 14:36
dnamorim
dnamorim reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@dnamorim dnamorim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has two commits that were already released in main:

Can you rebase with the release branch?

@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from a5a2422 to 796ab89 Compare January 29, 2024 11:02
@github-actions github-actions bot added type: feature New feature type: documentation Changes to documentation only and removed type: feature New feature labels Jan 29, 2024
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from 796ab89 to e1a9c51 Compare January 29, 2024 11:05
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature type: documentation Changes to documentation only labels Jan 29, 2024
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from e1a9c51 to 041f41d Compare January 29, 2024 11:33
@github-actions github-actions bot removed the type: feature New feature label Jan 29, 2024
@github-actions github-actions bot added the type: feature New feature label Jan 29, 2024
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from 041f41d to dbb4737 Compare January 30, 2024 15:33
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 30, 2024
@edupaulos edupaulos force-pushed the feat_join_relatedCommerceData_with_respective_editorial_data branch from dbb4737 to 03b4a7d Compare January 30, 2024 17:18
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Jan 30, 2024
@boliveira boliveira merged commit 87912d0 into dev-main-23-01-24 Jan 30, 2024
3 checks passed
@boliveira boliveira deleted the feat_join_relatedCommerceData_with_respective_editorial_data branch January 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnamorim dnamorim dnamorim left review comments

@richard190m richard190m richard190m approved these changes

@joaoprcosta joaoprcosta joaoprcosta approved these changes

@vinicaval vinicaval vinicaval approved these changes

@boliveira boliveira boliveira approved these changes

@danpadrinom danpadrinom Awaiting requested review from danpadrinom

Assignees

@edupaulos edupaulos

Labels
📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package type: feature New feature
Milestone
dev-main-23-01-24
Development

Successfully merging this pull request may close these issues.
6 participants
@edupaulos @boliveira @vinicaval @dnamorim @joaoprcosta @richard190m