fix: fix tracking of uniqueViewId and previousUniqueViewId in analytics #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 analytics
danielbento92
approved these changes
Jan 30, 2024
diegogriep
approved these changes
Jan 30, 2024
talbertosilva
approved these changes
Jan 30, 2024
This fixes a problem where if two or more consecutive calls to analytics.page are added before the microtask queue has an opportunity to run, the same values for the `uniqueViewId` and `previousUniqueViewId` parameters for both the Omnitracking events that would be generated. While this works, this is a temporary fix since there are other values that suffer from the same problem, for example, the consent and user values can be affected since they are globally shared. A deeper change to analytics would be needed to tackle this but as this is not a very common case, we will leave it like that for now.
boliveira
force-pushed
the
fix_analytics_api
branch
from
d285643
to
7abfb21
Compare
github-actions
bot
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a problem where if two or more consecutive calls
to analytics.page are added before the microtask queue has an
opportunity to run, the same values for the
uniqueViewIdand
previousUniqueViewIdparameters for both the Omnitrackingevents that would be generated. While this works, this is a temporary
fix since there are other values that suffer from the same problem,
for example, the consent and user values can be affected since they
are globally shared. A deeper change to analytics would be needed
to tackle this but as this is not a very common case, we will leave it
like that for now.
Dependencies
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement