Rework type name resolves to able to change the implementation #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarii-piontko
force-pushed
the
master
branch
from
b414f4c
to
7a9a200
Compare
nazarii-piontko
force-pushed
the
master
branch
from
7a9a200
to
28bd63f
Compare
esskar
reviewed
Apr 17, 2024
| var package = protoFields.Package; | ||
| if (string.IsNullOrEmpty(package)) | ||
| { | ||
| package = protoFields.Options.CsharpNamespace; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IAsyncSchemaRegistryTypeNameResolverfor Protobuf and Avro schemas.TryAdd...methods to add service to the DI container if it is not there already. It is necessary to not override the customer-defined implementation of the name resolver.IConfluentAvroTypeNameResolverandIConfluentProtobufTypeNameResolverto have the possibility to register different name resolvers for Avro and Protobuf schemas.Fixes # (issue)
Make ConfluentProtobufTypeNameResolver more flexible on type name construction #404
How Has This Been Tested?
ConfluentProtobufTypeNameResolverimplementation.TryAdd...methods.samples/KafkaFlow.Sample.SchemaRegistry.Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement