Fix: Issues with cooperative-sticky strategy #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work 🚀 with this PR. Can you also add some tests as well to validate this use case? 🙇 |
|
We'd love to have this feature. Any updates on the implementation of the tests? |
Unit tests were added 2 months ago. |
|
Great. Any updates on getting the feature reviewed @dosper7? |
|
Great to see it happening! Thanks @golanbz for working on it! |
brmagadutra
approved these changes
Feb 3, 2025
|
@golanbz thanks for the contribution! Can you please rebase the PR with master. |
|
Hooray! Things are moving! I am so excited! :) |
brmagadutra
force-pushed
the
fix/sticky-cooperative-strategy
branch
from
0816113 to
0683df5
Compare
|
@golanbz can you please check the errors on the lint step? Also, rebase with the latest changes from master. |
golanbz
force-pushed
the
fix/sticky-cooperative-strategy
branch
2 times, most recently
from
e37fb6f to
548cd18
Compare
- Added support for consumer strategies that do not act as "stop the world" scenarios (e.g., cooperative sticky). - Enabled automatic committing with `confluent auto commit: true` when the consumer strategy is cooperative sticky. - Referenced open librdkafka issue: confluentinc/librdkafka#4059.
test: add unit tests and fix bug in ClusterConfiguration - Added 3 new test files to improve coverage: - ConsumerConfigurationBuilderTests.cs - KafkaConfigTests.cs - PartitionAssignmentStrategyTests.cs - Fixed a bug in ClusterConfiguration related to AutoCommitInterval initialization chore: update AutoCommitInterval to 100ms in Cooperative-sticky sample - Updated AutoCommitInterval in Cooperative-sticky sample Program.cs to 100ms. fix: resolve Codacy issues - Fixed various code quality issues flagged by Codacy.
golanbz
force-pushed
the
fix/sticky-cooperative-strategy
branch
2 times, most recently
from
35f0650 to
d970b5d
Compare
MiguelCosta
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cooperative-stickyprotocol #456.confluent.auto.commit: truefor the cooperative sticky consumer strategy, instead of relying solely on manual commits. This change is particularly relevant due to the ongoing issue in librdkafka (see: Consumers should not be able to commit during a rebalance confluentinc/librdkafka#4059).How Has This Been Tested?
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement.