New places api #943
Merged
New places api #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2024
|
Awaiting your confirmation to proceed with the merge |
rafecolton
suggested changes
Sep 17, 2024
rafecolton
suggested changes
Oct 1, 2024
@FaridSafi @rafecolton The PR here is ready for review as it works well with the new places API. |
|
Thank you @rojiphil, merged and deployed. Could you please double check if the published version is OK ? |
rafecolton
reviewed
Oct 4, 2024
|
|
||
| request.withCredentials = requestShouldUseWithCredentials(); | ||
| setRequestHeaders(request, getRequestHeaders(props.requestUrl)); | ||
|
|
||
| request.send(); | ||
| if (props.isNewPlacesAPI) { | ||
| const { key, locationbias, types, ...rest } = props.query; |
There was a problem hiding this comment.
Is it necessary to maintain locaitonbias in here?
There was a problem hiding this comment.
locationbias is for old Places API and can be stripped whereas locationBias is what is expected in new Places API. We maintain locationBias for new Places API.
There was a problem hiding this comment.
Ah got it, thank you for explaining 👍
|
Thanks @FaridSafi! I see the version published on NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FaridSafi Coming from this issue, this PR attempt to support
Autocomplete (New)andPlace Details (New)API. Also, this PR addssessionTokensupport.