fix XorBinaryFuse32

FastFilter · Nov 22, 2024 · 294c48e · 294c48e
1 parent 6b64b54
commit 294c48e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse32.java b/fastfilter/src/main/java/org/fastfilter/xor/XorBinaryFuse32.java
@@ -238,7 +238,7 @@ public boolean mayContain(long key) {
         h1 ^= (int) ((hh >> 18) & segmentLengthMask);
         h2 ^= (int) ((hh) & segmentLengthMask);
         f ^= fingerprints[h0] ^ fingerprints[h1] ^ fingerprints[h2];
-        return (f & 0xff) == 0;
+        return (f & 0xffffffffL) == 0;
     }
 
     @Override

diff --git a/fastfilter/src/test/java/org/fastfilter/TestAllFilters.java b/fastfilter/src/test/java/org/fastfilter/TestAllFilters.java
@@ -107,6 +107,14 @@ public static void main(String... args) {
             System.out.println("size " + size);
             test(TestFilterType.XOR_BINARY_FUSE_8, size, 0, true);
         }
+        for (int size = 1; size <= 100; size++) {
+            System.out.println("size " + size);
+            test(TestFilterType.XOR_BINARY_FUSE_32, size, 0, true);
+        }
+        for (int size = 100; size <= 100000; size *= 1.1) {
+            System.out.println("size " + size);
+            test(TestFilterType.XOR_BINARY_FUSE_32, size, 0, true);
+        }
         for (int size = 1_000_000; size <= 8_000_000; size *= 2) {
             System.out.println("size " + size);
             testAll(size, true);

diff --git a/jmh/src/main/java/org/fastfilter/ConstructionState.java b/jmh/src/main/java/org/fastfilter/ConstructionState.java
@@ -24,6 +24,7 @@ public class ConstructionState {
             "XOR_8",
             "XOR_16",
             "XOR_BINARY_FUSE_8",
+            "XOR_BINARY_FUSE_32",
             "XOR_PLUS_8",
             "CUCKOO_8",
             "CUCKOO_16",