added XorBinaryFuse32 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running tests. |
|
That's very strange, but it seems to pass the tests (I haven't changed anything, just tried running it on my own self-hosted runner and then reverted back ) . |
|
@dkwi Yes, it looks like it passes the tests. What is strange? |
|
The fact the tests passed without any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 32bit implementation of the binary fuse filter.
It's basically a copy-paste with some types changed.
I've decided not to implement a generic version of this since java generics would require lots of boxing so performance and memory usage might take a hit.