Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with absolute output paths #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pluederitz
Copy link

maybe it fix also similar issue: #36

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation
  • Other

Description

Use resolve than join to compute fullFilePath to handle outputPath correctly if set to an absolute path.
Resolve is checking if a parameter is an absolute path and ignore preceding paths.
Join always concatenate all path parameters which add an base path to the outputPath - that creates a non-existing path if outputPath is already absolute.

Checks

  • PR adheres to the code style of this project
  • Related issues linked using fixes #number
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Lint and build have passed locally by running pnpm lint && pnpm build
  • Code changes have been verified in local
  • Documentation added/updated if necessary

Additional Context

I use vite with absolute output paths to generate builds.

could also fix similar issue: FatehAK#36
@vchernin vchernin mentioned this pull request Jun 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant