Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready for review #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Ready for review #1

wants to merge 7 commits into from

Conversation

Fidesnoella
Copy link
Owner

No description provided.

@github-pages github-pages bot temporarily deployed to github-pages October 17, 2022 18:30 Inactive
@netlify
Copy link

netlify bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for the-gym-google-cloning ready!

Name Link
🔨 Latest commit 9f40cf6
🔍 Latest deploy log https://app.netlify.com/sites/the-gym-google-cloning/deploys/634eb13fbedf07000933faf6
😎 Deploy Preview https://deploy-preview-1--the-gym-google-cloning.netlify.app/src
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-pages github-pages bot temporarily deployed to github-pages October 17, 2022 18:42 Inactive
@github-pages github-pages bot temporarily deployed to github-pages October 17, 2022 18:45 Inactive
@github-pages github-pages bot temporarily deployed to github-pages October 17, 2022 21:54 Inactive
@github-pages github-pages bot temporarily deployed to github-pages October 17, 2022 22:29 Inactive
mbukeRepo
mbukeRepo approved these changes Oct 18, 2022
View reviewed changes
Copy link

@mbukeRepo mbukeRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Odile078
Odile078 suggested changes Oct 18, 2022
View reviewed changes
Copy link

@Odile078 Odile078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job implementing the cloned design, just a few things to add before you're done

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
Odile078
Odile078 approved these changes Oct 18, 2022
View reviewed changes
Copy link

@Odile078 Odile078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, Looks Good !

mbukeRepo
mbukeRepo suggested changes Oct 18, 2022
View reviewed changes
Copy link

@mbukeRepo mbukeRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done , but please make these changes:
✔️ make footer stick on the bottom
✔️ remove svgs and use img tag to include them on the page

@Fidesnoella Fidesnoella requested a review from mbukeRepo October 18, 2022 13:59
mbukeRepo
mbukeRepo approved these changes Oct 18, 2022
View reviewed changes
Copy link

@mbukeRepo mbukeRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odile078 Odile078 Odile078 approved these changes

@mbukeRepo mbukeRepo mbukeRepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidesnoella @Odile078 @mbukeRepo