Skip to content

Commit

Permalink
FOCUS #128: Add contributors and other minor cleanup (#132)
Browse files Browse the repository at this point in the history
Contributor list + clean up tasks
  • Loading branch information
udam-f2 authored Jun 24, 2023
1 parent 303dd64 commit 5d3b757
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 29 deletions.
3 changes: 1 addition & 2 deletions specification/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ STYLE="working_draft"
endif
PDF_MARGINS=--variable margin-top=15 --variable margin-bottom=25 --variable margin-left=0 --variable margin-right=10
PDF_FOOTER=--pdf-engine-opt="--footer-right" --pdf-engine-opt="[page] of [topage]" --pdf-engine-opt="--footer-font-name" --pdf-engine-opt="Palatino" --pdf-engine-opt="--footer-font-size" --pdf-engine-opt="8"
SPEC_SOURCE_FILES=$(filter-out spec.md, $(wildcard *.md*)) $(wildcard dimensions/*.md*) $(wildcard attributes/*.md*) $(wildcard metrics/*.md*) $(wildcard appendix/*.md*) $(wildcard appendix/normalized_dimensions/*.md*)
SPEC_SOURCE_FILES=$(filter-out spec.md, $(wildcard *.md*)) $(wildcard dimensions/*.md*) $(wildcard attributes/*.md*) $(wildcard metrics/*.md*) $(wildcard appendix/*.md*)
SPEC_SOURCE_MDFILES=$(filter-out %.mdpp, $(SPEC_SOURCE_FILES))
export TOCDEPTH=2
all: spec.md spec.pdf spec.html
Expand All @@ -27,7 +27,6 @@ endif
./validate_includes.py metrics
./validate_includes.py attributes
./validate_includes.py appendix
./validate_includes.py appendix/normalized_dimensions
PYTHONPATH=../vendored/ $(MARKDOWNPP) spec.mdpp -o $@
$(PYMARKDOWNLNT) --config markdownlnt.cfg scan $(SPEC_SOURCE_MDFILES)
$(PYMARKDOWNLNT) --config markdownlnt.cfg scan $@
Expand Down
2 changes: 0 additions & 2 deletions specification/appendix/appendix.mdpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@

!INCLUDE "grouping_constructs_for_resources_and_or_services.md",1
!INCLUDE "origination_of_cost_data.md",1

!INCLUDE "normalized_dimensions/normalized_dimensions.mdpp",1
12 changes: 0 additions & 12 deletions specification/appendix/normalized_dimensions/chargetype.md

This file was deleted.

This file was deleted.

34 changes: 31 additions & 3 deletions specification/contributors.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
## Contributors

* A
* B
* C
Thanks to the following FOCUS members for their contributions to this work.

* Amit Wadhwa (Google)
* Chandra Deverajan (CloudTrakr)
* Christopher Harris (Datadog)
* Elene Rundle (Google)
* Erik Peterson (CloudZero)
* Graham Murphy (Australian Retirement Trust)
* Irena Jurica (Neos)
* Jason Kelly (Anglepoint Group Inc)
* Joe Ferrero (DB Gurus Inc.)
* John Grubb (platform.sh)
* Josh Kwon (Ternary)
* Karl Kraft (Walmart)
* Mark Krawczeniuk (NetApp)
* Michael Arkoosh (Vega)
* Michael Flanakin (Microsoft)
* Mike Fuller (FinOps Foundation)
* Mike Polson (VMWare)
* Nicolas Fonrose (Teevity)
* Ray Ding (Accenture)
* Ricardo Triana (Accenture)
* Riley Jenkins (Domo)
* Rodney Joyce (CloudMonitor)
* Rupa Patel (Google)
* Sanjna Srivatsa (VMWare)
* Tatiana Dubovchenko (Flexera)
* Tery Morgan (Microsoft)
* Tim O'Brien (Walmart)
* Trig Ghosh (Accenture)
* Udam Dewaraja (FinOps Foundation)
4 changes: 2 additions & 2 deletions specification/dimensions/billingcurrency.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Billing Currency is an identifier that represents the currency that a charge for resources and/or services was billed in. Billing Currency is commonly used in scenarios where costs need to be grouped or aggregated.

The BillingCurrency column MUST be present in the billing data. BillingCurrency MUST match the currency used in the invoice generated by the invoice issuer. This column must be of type String and MUST NOT contain null values. BillingCurrency MUST conform to [FOCUS Currency Code Format](#currencycodeformatrequirements) requirements.
The BillingCurrency column MUST be present in the billing data. BillingCurrency MUST match the currency used in the invoice generated by the invoice issuer. This column must be of type String and MUST NOT contain null values. BillingCurrency MUST conform to [FOCUS Currency Code Format](#currencycodeformat) requirements.

## Column ID

Expand All @@ -24,7 +24,7 @@ Represents the currency that a charge was billed in.
| Data type | String |
| Allows nulls | False |
| Value format | list-of-values |
| Allowed Values | Meets [FOCUS Currency Code Format](#currencycodeformatrequirements) requirements |
| Allowed Values | Meets [FOCUS Currency Code Format](#currencycodeformat) requirements |

## Introduced (version)

Expand Down
10 changes: 9 additions & 1 deletion specification/dimensions/chargetype.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,15 @@ after-the-fact adjustment (e.g., credits), or taxes.
| Data type | String |
| Allows nulls | False |
| Value format | list-of-values |
| Allowed values | `Adjustment`, `Purchase`, `Tax`, `Usage` |

Allowed values:

| Value | Description |
|:-----------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Adjustment | Any adjustments that are applied after the original usage or purchase record. Adjustments may be related to multiple charges. |
| Purchase | Charges for the acquisition of a service or resource bought upfront or on a recurring basis. |
| Tax | Applicable taxes that are levied by the relevant authorities. Tax charges may vary depending on factors such as the location, jurisdiction, and local or federal regulations. |
| Usage | Charges based on the quantity of a service or resource that was consumed over a given period of time. |

## Introduced (version)

Expand Down

0 comments on commit 5d3b757

Please sign in to comment.