Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Add and delete various icons #49

Merged
merged 1 commit into from
Mar 18, 2019
Merged

[update] Add and delete various icons #49

merged 1 commit into from
Mar 18, 2019

Conversation

nt1m
Copy link
Contributor

@nt1m nt1m commented Mar 7, 2019

Fixes #3
Fixes #30
Fixes #31
Fixes #36

@nt1m
Copy link
Contributor Author

nt1m commented Mar 7, 2019

@bwinton Can you please review this PR ? Thanks!

@bwinton
Copy link
Collaborator

bwinton commented Mar 7, 2019

Could you run npm run build, to optimize the icons? Aside from that, the code looks fine. @shorlander, @bryanbell, or @brassy- should probably review the style of the icons before we merge…

@nt1m
Copy link
Contributor Author

nt1m commented Mar 7, 2019

@bwinton These are all directly ported from m-c.

Unfortunately, npm run build rips out all the license headers, but I can look at this later today.

@nt1m
Copy link
Contributor Author

nt1m commented Mar 7, 2019

Just to ease-up UX review:

  • The autoplay icons were introduced in bug 1461656, and I believe @bryanbell created them
  • The pocket outline icon was introduced in bug 1462790, and was created by @shorlander
  • The tablet icon was introduced in bug 1383898 and was created by @brampitoyo
  • The policy engine icons were introduced and bug 1485636 and also were created by Bram
  • The left sidebar icon is just a flipped version of the right sidebar icon, and it's been introduced in bug 1347543
  • The cookie icons were introduced in bug 1484312
  • The cryptomining/fingerprinting icons were introduced in bug 1522567

@shorlander
Copy link

Looks good to me. Thank you!

@bwinton bwinton merged commit ab12978 into FirefoxUX:master Mar 18, 2019
@nt1m nt1m deleted the more-icons branch March 18, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants