Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct request dispatch #101

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Direct request dispatch #101

merged 3 commits into from
Mar 8, 2019

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Mar 7, 2019

This removes the last piece of request-specific state from the dispatcher, which is more progress on #98

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #101 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     96.59%   96.53%   -0.06%     
+ Complexity      131      129       -2     
============================================
  Files            22       22              
  Lines           470      462       -8     
============================================
- Hits            454      446       -8     
  Misses           16       16
Impacted Files Coverage Δ Complexity Δ
src/Dispatcher.php 98.71% <100%> (-0.12%) 24 <11> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e4929...3e10d31. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #101 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     96.59%   96.53%   -0.06%     
+ Complexity      131      129       -2     
============================================
  Files            22       22              
  Lines           470      462       -8     
============================================
- Hits            454      446       -8     
  Misses           16       16
Impacted Files Coverage Δ Complexity Δ
src/Dispatcher.php 98.71% <100%> (-0.12%) 24 <11> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e4929...9803272. Read the comment docs.

@Firehed Firehed merged commit 77a7f33 into master Mar 8, 2019
@Firehed Firehed deleted the direct_request_dispatch branch March 8, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant