This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
added support for functions and tables in markdown #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to lustache there are many fun things that we can do with the templates, such as functions and tables: https://github.com/Olivine-Labs/lustache/blob/master/README.md
Except for this:
https://github.com/Fizzadar/Luapress/blob/develop/luapress/util.lua#L152
Now I don't claim to be a smart man or anything, but I'm pretty sure that's just reading everything in as a string. The fix involved extending the syntax of markdown a bit more, and the results are overall pretty great. You can do a lot more with lustache now.
There are some caveats though:
https://github.com/Olivine-Labs/lustache/blob/master/spec/render_spec.lua#L149
At least these last two cases fail for no apparent reason when tried in luapress. I suspect something far more foul and malignant is the reason for this, but I'm not interested in digging deeper.
Your turn.