Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iluvatar] Support tensor parallel heterogeneous training #134

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

njuerect
Copy link
Contributor

@njuerect njuerect commented Jun 7, 2024

This PR adds support for training LLM on heterogeneous devices with different tensor parallel sizes.

@@ -0,0 +1,292 @@
# Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not copy a train_llama.py, which should be unified training entrance. You can put the functional changes that must be rewritten in hetero folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! This will definitely be improved in the next pull request.

@@ -0,0 +1,680 @@
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the train_llama.py above.

Copy link
Contributor

@aoyulong aoyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoyulong aoyulong merged commit 9838ede into FlagOpen:main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants