fix: Flaky test_offline_mode__local_evaluation__correct_fallback (#103

)

.pre-commit-config.yaml

@@ -5,7 +5,7 @@ repos:
       - id: mypy
         args: [--strict]
         additional_dependencies:
-          [pydantic, pytest, pytest_mock, types-requests, flagsmith-flag-engine, responses, sseclient-py]
+          [freezegun, pydantic, pytest, pytest_mock, types-requests, flagsmith-flag-engine, responses, sseclient-py]
   - repo: https://github.com/PyCQA/isort
     rev: 5.13.2
     hooks:

pyproject.toml

@@ -27,6 +27,7 @@ pytest-mock = "^3.6.1"
 pre-commit = "^2.17.0"
 responses = "^0.24.1"
 types-requests = "^2.32"
+freezegun = "^1.5.1"
 
 [tool.mypy]
 plugins = ["pydantic.mypy"]

tests/test_flagsmith.py

@@ -3,6 +3,7 @@
 import typing
 import uuid
 
+import freezegun
 import pytest
 import requests
 import responses
@@ -527,6 +528,7 @@ def test_flagsmith_uses_offline_handler_if_set_and_no_api_response(
 
 
 @responses.activate()
+@freezegun.freeze_time()
 def test_offline_mode__local_evaluation__correct_fallback(
     mocker: MockerFixture,
     environment_model: EnvironmentModel,
@@ -546,10 +548,6 @@ def test_offline_mode__local_evaluation__correct_fallback(
         offline_handler=mock_offline_handler,
     )
 
-    # We only verify local evaluation mode init phase here.
-    # Prevent additional API calls.
-    flagsmith.environment_data_polling_manager_thread.stop()
-
     # When
     environment_flags = flagsmith.get_environment_flags()
     identity_flags = flagsmith.get_identity_flags("identity", traits={})