fix: Set the environment for local evaluation mode on init #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
approved these changes
Mar 13, 2024
|
Sorry @zachaysan looks like some big PRs got merged so you've got some conflicts here. Thankfully just in the tests! |
|
@zachaysan I handled the conflicts here. |
matthewelwell
deleted the
fix/set_local_evaluation_environment_before_init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This sets up the environment for the first time before booting the update cycle. This avoids a failure where waiting on a network request in one thread allows the primary thread to attempt to get flags before the local cache is set.