Remove pytz and replace usage with core python modules #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh interesting thanks for the contribution will take a look! cc @gagantrivedi |
khvn26
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
LGTM 👍
Please rebase to latest main and we'll merge, @MerijnBol .
Pytz is deprecated since Python 3.9. You might want to keep it for backwards compatibility for Python 3.8. However, turning naive datetimes into UTC timezone datetimes seems also possible in Python 3.8 without using the pytc library.
|
@khvn26 done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry complained about
pytzdependency issues while I was trying to install Flagsmith 3.6.0. Started looking through the code and doesn't look like you actually needpytz.Maybe I'm missing something. Hope this makes sense.