feat: Support transient identities and traits #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support transient identities and traits - Bump requests - Bump mypy
khvn26
requested review from
a team and
zachaysan
and removed request for
a team
khvn26
force-pushed
the
feat/transient-identities-and-traits
branch
from
10e330b to
f38df63
Compare
khvn26
force-pushed
the
feat/transient-identities-and-traits
branch
from
f3e3433 to
a8126ac
Compare
zachaysan
approved these changes
Jul 18, 2024
Comment on lines
+375
to
376
| body: typing.Optional[JsonType] = None, | ||
| ) -> typing.Any: |
There was a problem hiding this comment.
Shouldn't the return type be JsonType?
There was a problem hiding this comment.
The return type here corresponds to response.json() type, which is typing.Any.
Casting to a specific type is responsibility of the caller, see e.g.
flagsmith-python-client/flagsmith/flagsmith.py
Lines 358 to 359 in b0e85d8
matthewelwell
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
requestsmypy