Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: docker-compose: first commit #153

Closed
wants to merge 3 commits into from
Closed

feature: docker-compose: first commit #153

wants to merge 3 commits into from

Conversation

kfields
Copy link
Contributor

@kfields kfields commented Oct 2, 2021

Adds Docker Compose Support

This is more radical than I intended it to be. I had to move traveller into a subdirectory named web because Docker stats all the files in the same directory of the Dockerfile which creates a problem because of docker volume permissions. All of the repos I've seen are structured like this and now I know why. It would be nice if you could create volumes out of the source tree, but where else would they go that would be cross OS compatible? I also looked into running Docker as a different user, etc. All of the alternative solutions seem to have caveats.

Another contentious issue is that I changed the database to use PostgreSQL. I realize this has implications for deployment and I can change it back to MySQL if need be.

This is in competition with #152, the main difference is that it uses an Alpine image and this uses Debian. Please review

@kfields kfields mentioned this pull request Oct 2, 2021
@Abdur-rahmaanJ
Copy link
Member

@kfields hum no difference supposedly if we are using mysql but better just in case

@kfields kfields closed this by deleting the head repository Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants