Skip to content

Commit

Permalink
This should apply to all consumers of ipc_shm_arena_lend lib; as oppo…
Browse files Browse the repository at this point in the history
…sed to individual tests that use it. So moved from there to here; was deleted recently from there.
  • Loading branch information
ygoldfeld committed Dec 20, 2023
1 parent a6c1e61 commit 7d81736
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ jobs:
cd ${{ env.install-dir }}/bin
mkdir -p logs/ipc_shm_arena_lend_link_test
SUPP_DIR_A=${{ github.workspace }}/flow/src
# As of this writing there are certain harmless UBSAN triggers within jemalloc, and ipc_shm_arena_lend
# As of this writing there are certain harmless UBSAN, TSAN triggers within jemalloc, and ipc_shm_arena_lend
# is the thing that depends on jemalloc, and of the `link_test`s this is the only one that links
# ipc_shm_arena_lend (directly or otherwise). Hence compared to the other `link_test`s this adds the
# ipc_shm_arena_lend suppression context.
Expand Down Expand Up @@ -791,11 +791,10 @@ jobs:
{ cat $SUPP_DIR_A/${{ env.san-suppress-cfg-in-file1 }} $SUPP_DIR_A/${{ env.san-suppress-cfg-in-file2 }} \
> ${{ env.san-suppress-cfg-file }} 2> /dev/null; } || true
if [ "$3" == '-shm-j' ]; then
# SHM-jemalloc mode => jemalloc is in fact exercised => suppress jemalloc stuff. (UBSAN)
# SHM-jemalloc mode => jemalloc is in fact exercised => suppress jemalloc stuff. (UBSAN, TSAN)
SUPP_DIR_B=${{ github.workspace }}/ipc_shm_arena_lend/src
{ cat $SUPP_DIR_B/${{ env.san-suppress-cfg-in-file1 }} $SUPP_DIR_B/${{ env.san-suppress-cfg-in-file2 }} \
>> ${{ env.san-suppress-cfg-file }} 2> /dev/null; } || true
# On the other hand no TSAN suppressions needed. Cf. SHM-classic:
elif [ "$3" == '-shm-c' ]; then
# SHM-classic mode => TSAN gets confused by opposing process (e.g., client) allocating while current process
# (e.g., accordingly, server) deallocates => false-positives when accessing SHM-mapped areas. (TSAN)
Expand Down
2 changes: 1 addition & 1 deletion ipc_shm_arena_lend
1 change: 0 additions & 1 deletion test/suite/unit_test/sanitize/tsan/suppressions_clang.cfg
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Current version assumption: clang-15/16/17.

# TODO: Explain these in detail.
race:je_arena*
race:ipc::shm::arena_lend::Borrower_shm_pool_collection::open_shm_pool
race:ipc::session::shm::arena_lend::Shm_session_data::register_borrower_collection
race:ipc::session::shm::arena_lend::jemalloc::test::(anonymous namespace)::Test_client::~Test_client
Expand Down

0 comments on commit 7d81736

Please sign in to comment.