ASAN (clean!), UBSAN (clean!) jobs added -- nicely sanitized! MSAN also added but disabled, as our environment is not quite suitable. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto `main` here or at some other near-term opportunity.
…t attempt at ASAN, clang-17 only. (I have run this locally with clang-17 and LLVM-10 STL, with stuff passing nicely. Let us see what happens here.)
…the other clangs at least experimentally (might still limit it to one clang in the end; TBD).
…-behavior with undefined to match the clang flag; though that might be wrong; and if not functionally wrong then it is arguable undefined-behavior is nicer (TBD).
…nd all but TSAN are helped by -fno-omit-frame-pointer when compiling.
Also a number of changes for *SAN; and some minor fixes to merged-in code (e.g., no need to invoke the before-each-test stuff when running the "prepare" steps for transport_test; parentheses missing; no need to check for TSAN in the re-run-on-prev-step error, as it would not have failed if it was skipped anyway).
… some capnp code which should be fine).
…ch slow run-time down by up to like 5x.
…test failed; only then fail out of the run script.
…nit, seems nothing to do with our code yet... does not even get to main()).
… into different suppression files per compiler version (using symlinks for some though).
…e inside the main.yml.
…tion after that. Attempting to fix.
…tion after that. Attempting to fix.
…tion after that. Attempting to fix.
…omething close to the final matrix.
Tough but feel-good merge. I made additional minor changes. TODO: LTO-off needs to be reapplied, as merged-in code invokes CMake differently from before.
…go LTO. This may not be the most elegant way in terms of Python, but the essence is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.