TSAN caught subtle error when exiting transport_test (exercise mode); worker loop should be stopped before things that tasks posted-onto it touch get destroyed in dtor. So doing that now. Assuming I got that right transport_test will finish fine with TSAN, in exercise mode, at least in heap sub-mode (SHM-classic and SHM-jemalloc sub-modes TBD). Also updating submodules (comment/spacing only changes). #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… worker loop should be stopped before things that tasks posted-onto it touch get destroyed in dtor. So doing that now. Assuming I got that right transport_test will finish fine with TSAN, in exercise mode, at least in heap sub-mode (SHM-classic and SHM-jemalloc sub-modes TBD). Also updating submodules (comment/spacing only changes).
…mode, heap sub-mode (TODO: working on the remaining sub-modes -- SHM-* -- presently). Incidentally I do not feel we need the skip-transport-test switches anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.