After this transport_test runs with all applicable sanitizers and only a few suppressions targeted at the one mode/sub-mode (exercise, SHM-classic) that needs them. Plus one little suppression for sub-mode SHM-jemalloc. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mode SHM-classic, as TSAN is unable to follow the data structures properly between two processes in SHM.
…r transport_test exercise mode SHM-classic sub-mode. TODO: Use it in workflow.
…jemalloc likely-false-positives (je_arena*), same as colleague did for unit_test (ticket filed to absolutely ensure it is false-positive). 2, clang-13 *SAN no longer executed (while UBSAN and ASAN happened to be clearn for it, TSAN shows chaotic stack-trace-reporting behavior and therefore uncertain suppression behavior which needs to workly smoothly for TSAN especially); clang-15-16-17 remain. 3, disabling LTO for Debug (was disabled anyway inside CMake, so this is more stylistic); DebWithRelInfo (questionable but it is explained why in the comment nearby); all TSAN (also explained therein); the other *SAN already had LTO disabled. 4, locally I have observed hanging TSAN behavior in one more test; added to list of unit_test tests to skip just in case.
ygoldfeld
changed the title
…sed to individual tests that use it. So moved from there to here; was deleted recently from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing clang-13 (which leaves 15, 16, 17) *SAN jobs, due to some chaotic stack trace output for TSAN (ticket filed to look into it, but in meantime we have good *SAN coverage). Also disabling LTO for DebWithRelInfo and all DebWithRelInfo-*SAN jobs.