Bottom line: TSAN is now in good shape -- unit_test has been satisfactorily executed with ~all problems handled. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibly easier debugging (might affect outcomes though; will see at the end). Disabling unit_test suppressions to repro issues.
… as well not vary variables until we have to.
…large (in context) amount of TSAN warnings (which are false positives, confirmed; but see details in comment inside).
…have been handled (a couple false positives, one true-code fix, several test-code fixes); plus I have found (at least locally with clang-17; we will now see about pipeline including clang-15/16) that the tests my colleague skipped due to causing TSAN-locks-limit/hang can be run in a group separately from the othe other tests without triggering the problem. So this makes that change; will see if it runs as cleanly as it does for me locally.
…he other *SAN and reduced entropy in symbolization problems with which continue to pop up at least in clang-17 in... situations. Speaking of that, omitting Jemalloc_shm_pool_collection_test.Multithread_load for clang-17+TSAN, as it results in that damned intractable problem seen with transport_test/SHM-jemalloc with clang-17+TSAN. We skip the entire transport_test sub-mode in that case, so now doing that for just the aforementioned unit_test GTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.