Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure app reloads without using cache #1462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgjgh
Copy link
Contributor

@cgjgh cgjgh commented Nov 12, 2024

Description

After changes made in this PR #1455, this ensures app still reloads without cache to prevent issues like ones mentioned here: #817, fixed by adding more fine-grained error filtering to prevent errors that should trigger a redirect to auth, to instead result in opening fallback app.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cgjgh cgjgh marked this pull request as draft November 12, 2024 21:26
@cgjgh cgjgh marked this pull request as ready for review November 13, 2024 02:47
@cgjgh
Copy link
Contributor Author

cgjgh commented Nov 13, 2024

@joepavitt This is ready for review when it fits your busy schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant