Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove suffix from "Basic Demo" or "Demo" #104

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jul 3, 2024

Also, require a space before "Demo", so that other forms such as "Videodemo" would not be matched.

@javier-godoy javier-godoy requested review from mlopezFC and paodb July 3, 2024 15:32
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 46bfb46 into master Jul 3, 2024
1 of 2 checks passed
@paodb paodb deleted the correct-regexp branch July 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants