Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Tabs with EnhancedTabs in TabbedDemo #88

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

javier-godoy
Copy link
Member

No description provided.

@javier-godoy javier-godoy requested review from mlopezFC and paodb June 12, 2024 13:37
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
45.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 2b3fe14 into master Jun 12, 2024
1 of 2 checks passed
@paodb paodb deleted the enhanced-route-tabs branch June 12, 2024 13:43
@javier-godoy
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions 45.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Duplication on new code cannot be avoided because EnhancedTabs provides an API similar to that of Tabs but there is no common interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants