Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 17 commits into from
Jan 4, 2024
Merged

Initial implementation #1

merged 17 commits into from
Jan 4, 2024

Conversation

javier-godoy
Copy link
Member

No description provided.

@javier-godoy javier-godoy requested review from paodb and removed request for mlopezFC January 3, 2024 17:18
Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Javadocs are missing and license header need to be updated too.

@javier-godoy javier-godoy requested a review from paodb January 4, 2024 16:35
Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 5feec64 into master Jan 4, 2024
@paodb paodb deleted the initial-implementation branch January 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants