Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for polylines #112

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Add support for polylines #112

merged 3 commits into from
Jan 16, 2024

Conversation

paodb
Copy link
Member

@paodb paodb commented Jan 16, 2024

Close #102

According to the web component a Polygon and a Polyline are the same, the difference relies on the "closed" attribute: when "true" it's a polygon, when "false" it's a polyline. So this solution adds a GoogleMapPoly class containing all common logic and polygon and polyline classes extend from it.

@paodb paodb requested review from flang and javier-godoy January 16, 2024 18:51
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@flang flang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flang flang merged commit ee221e1 into master Jan 16, 2024
5 checks passed
@paodb paodb deleted the fix-issue-102 branch October 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for adding lines besides polygons
2 participants