Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing encoding for media links #11

Merged
merged 2 commits into from
May 14, 2024
Merged

fix: add missing encoding for media links #11

merged 2 commits into from
May 14, 2024

Conversation

paodb
Copy link
Member

@paodb paodb commented May 13, 2024

Close #10

@paodb paodb requested review from javier-godoy and mlopezFC May 13, 2024 11:50
@javier-godoy
Copy link
Member

I think this may be a breaking change, since instead of setShareLink("https%3A%2F%2Fgoogle.com%2Fhello%2F%3Fparam1%3DValue%2520Space%26lang%3Den'") (already encoded), now the URL is encoded by the component, and the user has to specify setShareLink(""https://google.com/hello/?param1=Value%20Space&lang=en"), which is a nice improvement, but breaks the current behavior.

javier-godoy
javier-godoy requested changes May 14, 2024
View reviewed changes
Copy link
Member

@javier-godoy javier-godoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update pom version

@paodb
Copy link
Member Author

paodb commented May 14, 2024

Update pom version

Done.

@paodb paodb requested a review from javier-godoy May 14, 2024 14:24
@javier-godoy javier-godoy merged commit 2b222d8 into master May 14, 2024
2 checks passed
@javier-godoy javier-godoy deleted the issue-10 branch May 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL spaces and Query Parameters Missing from link by Driver
2 participants
@paodb @javier-godoy