Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadocs #20

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix javadocs #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad8c71
docs: fix javadoc warnings
paodb Nov 7, 2024
d33c943
ci: configure Javadoc failOnWarnings
paodb Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
<configuration>
<quiet>true</quiet>
<doclint>none</doclint>
<failOnWarnings>false</failOnWarnings>
<failOnWarnings>true</failOnWarnings>
<links>
<link>https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}</link>
</links>
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/flowingcode/vaadin/addons/whatsappbutton/WhatsappButton.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public String getText() {
/**
* Sets an invite code.
*
* @param invite code the invite code to set
* @param inviteCode the invite code to set
*/
public void setInviteCode(String inviteCode) {
this.getElement().setProperty("invitecode", inviteCode);
Expand Down Expand Up @@ -171,7 +171,7 @@ public boolean isResponsive() {
/**
* Sets responsive option.
*
* @param redirect true to enable redirect
* @param responsive true to enable responsive option
*/
public void setResponsive(boolean responsive) {
this.getElement().setProperty("responsive", responsive);
Expand All @@ -190,7 +190,7 @@ public boolean isShowDialog() {
* Sets dialog option. If true, a dialog will show on button click indicating whatsapp is
* opening.
*
* @param redirect true to enable redirect
* @param dialog true to enable dialog option
*/
public void setShowDialog(boolean dialog) {
this.getElement().setProperty("dialog", dialog);
Expand Down
Loading