[MIRROR] Fixes a hard del in overlay lighting, fixes inconsistent lig…

…ht overlays [MDB IGNORE] (#842) * Fixes a hard del in overlay lighting, fixes inconsistent light overlays (#79939) --------- Co-authored-by: SkyratBot <[email protected]> Co-authored-by: Bloop <[email protected]>
Fluffy-Frontier · Nov 27, 2023 · 07ed061 · 07ed061
1 parent 2d89256
commit 07ed061
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/code/datums/components/overlay_lighting.dm b/code/datums/components/overlay_lighting.dm
@@ -266,6 +266,9 @@
 ///Used to determine the new valid current_holder from the parent's loc.
 /datum/component/overlay_lighting/proc/check_holder()
 	var/atom/movable/movable_parent = GET_PARENT
+	if(QDELETED(movable_parent))
+		set_holder(null)
+		return
 	if(isturf(movable_parent.loc))
 		set_holder(movable_parent)
 		return
@@ -274,7 +277,11 @@
 		set_holder(null)
 		return
 	if(isturf(inside.loc))
-		set_holder(inside)
+		// storage items block light, also don't be moving into a qdeleted item
+		if(QDELETED(inside) || istype(inside, /obj/item/storage))
+			set_holder(null)
+		else
+			set_holder(inside)
 		return
 	set_holder(null)
 
@@ -283,6 +290,7 @@
 /datum/component/overlay_lighting/proc/on_holder_qdel(atom/movable/source, force)
 	SIGNAL_HANDLER
 	if(QDELETED(current_holder))
+		set_holder(null)
 		return
 	UnregisterSignal(current_holder, list(COMSIG_QDELETING, COMSIG_MOVABLE_MOVED))
 	if(directional)