[MIRROR] Add a bounds check to prevent runtimes on the ripple shuttle…

… port [MDB IGNORE] (#865) * Add a bounds check to prevent runtimes on the ripple shuttle port (#79959) --------- Co-authored-by: SkyratBot <[email protected]> Co-authored-by: oranges <[email protected]>
Fluffy-Frontier · Nov 28, 2023 · 0eaed15 · 0eaed15
1 parent 79c379b
commit 0eaed15
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/code/modules/shuttle/shuttle.dm b/code/modules/shuttle/shuttle.dm
@@ -831,12 +831,10 @@
 	var/list/L1 = return_ordered_turfs(S1.x, S1.y, S1.z, S1.dir)
 
 	var/list/ripple_turfs = list()
-
-	for(var/i in 1 to L0.len)
+	var/stop = min(L0.len, L1.len)
+	for(var/i in 1 to stop)
 		var/turf/T0 = L0[i]
 		var/turf/T1 = L1[i]
-		if(!T0 || !T1)
-			continue  // out of bounds
 		if(!istype(T0.loc, area_type) || istype(T0.loc, /area/shuttle/transit))
 			continue  // not part of the shuttle
 		ripple_turfs += T1