Skip to content

Commit

Permalink
[MIRROR] Placing things in a paperbin actually plays sounds. (#1455) (#…
Browse files Browse the repository at this point in the history
…2426)

* Placing things in a paperbin actually plays sounds. (#81974)

## About The Pull Request

In contrast to my previous pr:
Really just changes the `user.transferItemToLoc(...)` used for
transferring paper to the bin to have a `silent = FALSE` parameter.
Also did it for pens for good measure, though I believe most pens don't
have such sounds yet.
## Why It's Good For The Game

Placing paper on a table makes sounds, placing paper in a bin makes no
sound. This feels awkward.
This changes that to actually make a sound.
Also adds `silent = FALSE` to placing pens on it for good measure,
though most pens don't have such sounds yet.
## Changelog
:cl:
sound: Placing paper in a paperbin is no longer silent.
/:cl:

* Placing things in a paperbin actually plays sounds.

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: _0Steven <[email protected]>
  • Loading branch information
3 people authored Mar 17, 2024
1 parent 1546d9c commit 1874c43
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions code/modules/paperwork/paperbin.dm
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,15 @@
return
if(istype(I, /obj/item/paper))
var/obj/item/paper/paper = I
if(!user.transferItemToLoc(paper, src))
if(!user.transferItemToLoc(paper, src, silent = FALSE))
return
to_chat(user, span_notice("You put [paper] in [src]."))
paper_stack += paper
total_paper += 1
update_appearance()
else if(istype(I, /obj/item/pen) && !bin_pen)
var/obj/item/pen/pen = I
if(!user.transferItemToLoc(pen, src))
if(!user.transferItemToLoc(pen, src, silent = FALSE))
return
to_chat(user, span_notice("You put [pen] in [src]."))
bin_pen = pen
Expand Down

0 comments on commit 1874c43

Please sign in to comment.