[MIRROR] It is now possible to survive the Mansus [MDB IGNORE] (#24490)

* It is now possible to survive the Mansus  (#79131)

## About The Pull Request

Fixes #79113

There were a handful of bugs with the Mansus realm, this PR fixes them.

Firstly an most importantly, a refactor to damage handling touched the
"unholy determination" effect incorrectly (and I'm not even sure why?),
causing it to damage you instead of healing you most of the time. This
damage was not avoidable, so most people would be crit shortly after
entering the area and stay there.

Secondly, some of the heretic realms were unlit. A change to when
lazyloaded template atmosphere initialises means that the bonfires were
trying to light themselves with no air. Now they do this in
late_initialize instead, giving time for air to arrive.

Thirdly, the spooky hands were runtiming when passing through transit
tiles outside of the bounds of the heretic map. They shouldn't be
effected by shuttle drag anyway, so now they aren't.

Fourthly, I removed a row of empty space at the edge of the heretic map,
just because it annoyed me slightly.

Finally, while I was touching the heretic buff I made it heal you 1/4 as
much as it originally did. This is a balance change rather than a fix,
I'll atomise it out if it is controversial but I don't really expect it
to be.
In the future I would like to come back to these and make each realm
more specific to the path, because I think we could make these both more
exciting and more characterful.

## Why It's Good For The Game

Once it is working properly, the hand dodging minigame is actually
extremely forgiving, even if you don't move very much and get frequently
hit. This means some of those hits might actually add some tension.

## Changelog

:cl:
fix: You should be revived properly when entering the mansus realm
following a heretic sacrifice
fix: The buff which is supposed to heal you in the mansus realm will now
do that instead of unavoidably damaging you
balance: The mansus realm's healing buff heals for 25% as much as it did
before it was broken
/:cl:

* It is now possible to survive the Mansus

---------

Co-authored-by: Jacquerel <[email protected]>

_maps/templates/lazy_templates/heretic_sacrifice.dmm

@@ -761,13 +761,9 @@ ab
 ab
 ab
 ab
-ab
-ab
 "}
 (2,1,1) = {"
 ab
-ab
-Fd
 Fd
 Fd
 Fd
@@ -811,7 +807,6 @@ ab
 "}
 (3,1,1) = {"
 ab
-ab
 Fd
 jt
 jt
@@ -851,12 +846,10 @@ La
 La
 La
 La
-Fd
 ab
 "}
 (4,1,1) = {"
 ab
-ab
 Fd
 jt
 AY
@@ -896,12 +889,10 @@ AO
 wY
 Wb
 La
-Fd
 ab
 "}
 (5,1,1) = {"
 ab
-ab
 Fd
 wo
 AY
@@ -941,12 +932,10 @@ AO
 AO
 wY
 La
-Fd
 ab
 "}
 (6,1,1) = {"
 ab
-ab
 Fd
 wo
 AY
@@ -986,12 +975,10 @@ AO
 AO
 AO
 La
-Fd
 ab
 "}
 (7,1,1) = {"
 ab
-ab
 Fd
 jt
 AY
@@ -1031,12 +1018,10 @@ AO
 AO
 wY
 La
-Fd
 ab
 "}
 (8,1,1) = {"
 ab
-ab
 Fd
 En
 AY
@@ -1076,12 +1061,10 @@ AO
 wY
 jB
 La
-Fd
 ab
 "}
 (9,1,1) = {"
 ab
-ab
 Fd
 En
 fL
@@ -1121,12 +1104,10 @@ AO
 wY
 Wb
 La
-Fd
 ab
 "}
 (10,1,1) = {"
 ab
-ab
 Fd
 jt
 AY
@@ -1166,12 +1147,10 @@ AO
 wY
 Wb
 La
-Fd
 ab
 "}
 (11,1,1) = {"
 ab
-ab
 Fd
 wo
 fL
@@ -1211,12 +1190,10 @@ AO
 AO
 wY
 La
-Fd
 ab
 "}
 (12,1,1) = {"
 ab
-ab
 Fd
 wo
 AY
@@ -1256,12 +1233,10 @@ wY
 AO
 AO
 La
-Fd
 ab
 "}
 (13,1,1) = {"
 ab
-ab
 Fd
 jt
 AY
@@ -1301,12 +1276,10 @@ qn
 wY
 AO
 La
-Fd
 ab
 "}
 (14,1,1) = {"
 ab
-ab
 Fd
 jt
 jt
@@ -1346,13 +1319,10 @@ La
 La
 La
 La
-Fd
 ab
 "}
 (15,1,1) = {"
 ab
-ab
-Fd
 Fd
 Fd
 Fd
@@ -1396,7 +1366,6 @@ ab
 "}
 (16,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1436,12 +1405,10 @@ HQ
 HQ
 HQ
 HQ
-Fd
 ab
 "}
 (17,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1481,12 +1448,10 @@ St
 ui
 St
 HQ
-Fd
 ab
 "}
 (18,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1526,12 +1491,10 @@ Xt
 Vd
 ui
 HQ
-Fd
 ab
 "}
 (19,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1571,12 +1534,10 @@ hZ
 ui
 St
 HQ
-Fd
 ab
 "}
 (20,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1616,12 +1577,10 @@ RW
 RW
 St
 HQ
-Fd
 ab
 "}
 (21,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1661,12 +1620,10 @@ St
 RW
 St
 HQ
-Fd
 ab
 "}
 (22,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1706,12 +1663,10 @@ JJ
 ui
 St
 HQ
-Fd
 ab
 "}
 (23,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1751,12 +1706,10 @@ ui
 ui
 St
 HQ
-Fd
 ab
 "}
 (24,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1796,12 +1749,10 @@ rP
 ui
 St
 HQ
-Fd
 ab
 "}
 (25,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1841,12 +1792,10 @@ RW
 cS
 ui
 HQ
-Fd
 ab
 "}
 (26,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1886,12 +1835,10 @@ Yp
 Xt
 St
 HQ
-Fd
 ab
 "}
 (27,1,1) = {"
 ab
-ab
 Fd
 fO
 fO
@@ -1931,13 +1878,10 @@ HQ
 HQ
 HQ
 HQ
-Fd
 ab
 "}
 (28,1,1) = {"
 ab
-ab
-Fd
 Fd
 Fd
 Fd
@@ -2017,9 +1961,7 @@ ab
 ab
 ab
 ab
-ab
-ab
-ab
+Fd
 ab
 ab
 ab

code/game/objects/structures/bonfire.dm

@@ -191,6 +191,11 @@
 	density = TRUE
 
 /obj/structure/bonfire/prelit/Initialize(mapload)
+	. = ..()
+	return INITIALIZE_HINT_LATELOAD
+
+// Late init so that we can wait for air to exist in lazyloaded templates
+/obj/structure/bonfire/prelit/LateInitialize()
 	. = ..()
 	start_burning()