Skip to content

Commit

Permalink
[MIRROR] Allows Signers to send COMSIG_MOB_SAY [MDB IGNORE] (#24982) (#…
Browse files Browse the repository at this point in the history
…612)

* Allows Signers to send COMSIG_MOB_SAY (#79677)

## About The Pull Request
By removing a conditional statement which prevented signers from sending
a `COMSIG_MOB_SAY` signal (for some reason), this PR fixes a few things
in one go:

- Sign language once again prints a notice that the signer raises or
lowers their eyebrows for exclamations and questions respectively.
- Tonal indicators (sign/typing icons that depict eyebrows raising or
lowering) are also working again.
- RuneChat is now punctuated the same as the chat box for Signers.

This PR is now atomic thanks to @ MrMelbert.

* Allows Signers to send COMSIG_MOB_SAY

---------

Co-authored-by: SkyratBot <[email protected]>
Co-authored-by: DBGit42 <[email protected]>
  • Loading branch information
3 people authored Nov 14, 2023
1 parent c8212f6 commit 28ae35f
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions code/modules/mob/living/living_say.dm
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,10 @@ GLOBAL_LIST_INIT(message_modes_stat_limits, list(
last_say_args_ref = REF(args)
#endif

if(!HAS_TRAIT(src, TRAIT_SIGN_LANG)) // if using sign language skip sending the say signal
// Make sure the arglist is passed exactly - don't pass a copy of it. Say signal handlers will modify some of the parameters.
var/sigreturn = SEND_SIGNAL(src, COMSIG_MOB_SAY, args)
if(sigreturn & COMPONENT_UPPERCASE_SPEECH)
message = uppertext(message)
// Make sure the arglist is passed exactly - don't pass a copy of it. Say signal handlers will modify some of the parameters.
var/sigreturn = SEND_SIGNAL(src, COMSIG_MOB_SAY, args)
if(sigreturn & COMPONENT_UPPERCASE_SPEECH)
message = uppertext(message)

var/list/message_data = treat_message(message) // unfortunately we still need this
message = message_data["message"]
Expand Down

0 comments on commit 28ae35f

Please sign in to comment.