Skip to content

Commit

Permalink
[MIRROR] Fixes Alien Hunter's Pounce Visuals (#829)
Browse files Browse the repository at this point in the history
* Fixes Alien Hunter's Pounce Visuals (#81322)

## About The Pull Request

Currently on live, when an alien hunter goes for a pounce, once the
pounce is completed the hunter will rise quite a distance slowly from
the floor as setting body_position_pixel_y_offset now is done with
animation as opposed to being instant. This looked extremely stupid, so
I went and fixed it. Initially, I was going to add some form of trait to
cancel out the smoothing effect from a shifting y offset, until I looked
at the sprite for alien pouncing and realized it was 96x96 for no
reason. For reference, 96x96 is the size of Bubblegum's sprites.

So, I just made the sprites 48x32, got rid of the unused sprites
(sentinel and drone both had pounce sprites but neither ever had that
ability iirc) and adjusted some of the pounce ability's internal offset
stuff to compensate and it looks perfectly fine now. Somehow made the
image file larger by 243 bytes according to Github but I guess it is
what it is.

## Why It's Good For The Game

The alien hunter ascending from 2 tiles below where it actually was
whenever it pounced was incredibly jarring. This fixes the problem.

## Changelog
:cl:
fix: Alien Hunter's pounce ability no longer has any weird offset issues
once the pounce is completed.
/:cl:

* Fixes Alien Hunter's Pounce Visuals

---------

Co-authored-by: IndieanaJones <[email protected]>
  • Loading branch information
2 people authored and FFMirrorBot committed Feb 7, 2024
1 parent 1dfac16 commit 337a15b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions code/modules/mob/living/carbon/alien/adult/caste/hunter.dm
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,14 @@
else //Maybe uses plasma in the future, although that wouldn't make any sense...
leaping = TRUE
//Because the leaping sprite is bigger than the normal one
body_position_pixel_x_offset = -32
body_position_pixel_y_offset = -32
body_position_pixel_x_offset = -8
update_icons()
ADD_TRAIT(src, TRAIT_MOVE_FLOATING, LEAPING_TRAIT) //Throwing itself doesn't protect mobs against lava (because gulag).
throw_at(A, MAX_ALIEN_LEAP_DIST, pounce_speed, src, FALSE, TRUE, callback = CALLBACK(src, PROC_REF(leap_end)))

/mob/living/carbon/alien/adult/hunter/proc/leap_end()
leaping = FALSE
body_position_pixel_x_offset = 0
body_position_pixel_y_offset = 0
REMOVE_TRAIT(src, TRAIT_MOVE_FLOATING, LEAPING_TRAIT)
update_icons()

Expand Down
Binary file modified icons/mob/nonhuman-player/alienleap.dmi
Binary file not shown.

0 comments on commit 337a15b

Please sign in to comment.