-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MIRROR] Add smooth transition between hidden and visible pipes (#1293)…
… (#2304) * Add smooth transition between hidden and visible pipes (#81800) ## About The Pull Request - Adds smooth transition between hidden and visible pipes, AKA “caps” and updates automated pipe icon generator to account mentioned changes. - Adds centering to missed atmos machinery, for example, unary vent is almost identical to passive, but the second one wasn't centered while hidden. - Fixes visual bug with extra and unremovable by normal means pixel offset on pipes constructed from `/obj/item/pipe`. - Fixes visual bug with visible cap on a hidden connector. I'm really sorry for this mess, but one-line fixes are okay, or are they? ## Why It's Good For The Game We're playing atmospherics simulator and pipes play an essential role in our rounds, people see them all the time and that's why pipes deserve to look a bit better. This project aims to resolve said issue by adding transition states, in current implementation they're just cut off when connected to a hidden segment. <details> <summary>Screenshots</summary> Before: ![dreamseeker_N9kXd8k5a9](https://github.com/tgstation/tgstation/assets/137328283/1e9915fc-53e6-4411-baa8-22ed67c0708e) After: ![dreamseeker_qxQepWXHwh](https://github.com/tgstation/tgstation/assets/137328283/72778646-46f5-4ebf-9988-10a87ead9768) Extra: ![dreamseeker_Lz0a55VoCE](https://github.com/tgstation/tgstation/assets/137328283/2b198ba9-74b1-4e54-901e-a72ab3af0a6a) </details> ## Changelog :cl: fix: Pipe connector no longer appears on a hidden connector. fix: Re-wrenched atmospherics pipes no longer get extra offset. fix: All unary devices like injectors, passive vents etc. are centered while hidden. image: Added smooth transition between hidden and visible pipes. /:cl: --------- * Add smooth transition between hidden and visible pipes --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Interception&? <[email protected]> Co-authored-by: san7890 <[email protected]>
- Loading branch information
1 parent
4aee11c
commit 340a736
Showing
15 changed files
with
133 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.