Skip to content

Commit

Permalink
[MIRROR] Makes BSA logging easier to find (#414)
Browse files Browse the repository at this point in the history
* Makes BSA logging easier to find (#80893)

## About The Pull Request
Admins keep goofing up looking for BSA logs because they currently just
say "an artillery strike" and not "a _bluespace_ artillery strike".
Hopefully this makes it more clear.

I have no clue if this is blocked under the feature freeze, if it is
I'll just reopen it in February.

## Why It's Good For The Game
Us admins have smooth brains sometimes and try to find something using
the most logical terminology. Whoever put this logging in assumed we'd
be smart enough to search for "artillery" and not "bluespace artillery".

## Changelog
:cl:
admin: Made logging for BSA targeting and firing easier to find for
admins.
/:cl:

* Makes BSA logging easier to find

---------

Co-authored-by: Vekter <[email protected]>
Co-authored-by: NovaBot <[email protected]>
  • Loading branch information
3 people authored and FFMirrorBot committed Jan 12, 2024
1 parent ff80856 commit 55d9ecf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 5 additions & 5 deletions code/modules/station_goals/bsa.dm
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,12 @@ GLOBAL_VAR_INIT(bsa_unlock, FALSE)
)
if(!blocker)
message_admins("[ADMIN_LOOKUPFLW(user)] has launched an artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)].")
user.log_message("has launched an artillery strike targeting [AREACOORD(bullseye)].", LOG_GAME)
message_admins("[ADMIN_LOOKUPFLW(user)] has launched a bluespace artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)].")
user.log_message("has launched a bluespace artillery strike targeting [AREACOORD(bullseye)].", LOG_GAME)
explosion(bullseye, devastation_range = ex_power, heavy_impact_range = ex_power*2, light_impact_range = ex_power*4, explosion_cause = src)
else
message_admins("[ADMIN_LOOKUPFLW(user)] has launched an artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)] but it was blocked by [blocker] at [ADMIN_VERBOSEJMP(target)].")
user.log_message("has launched an artillery strike targeting [AREACOORD(bullseye)] but it was blocked by [blocker] at [AREACOORD(target)].", LOG_GAME)
message_admins("[ADMIN_LOOKUPFLW(user)] has launched a bluespace artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)] but it was blocked by [blocker] at [ADMIN_VERBOSEJMP(target)].")
user.log_message("has launched a bluespace artillery strike targeting [AREACOORD(bullseye)] but it was blocked by [blocker] at [AREACOORD(target)].", LOG_GAME)
/obj/machinery/bsa/full/proc/reload()
Expand Down Expand Up @@ -344,7 +344,7 @@ GLOBAL_VAR_INIT(bsa_unlock, FALSE)
if(isnull(options[victim]))
return
target = options[victim]
log_game("[key_name(user)] has aimed the artillery strike at [target].")
log_game("[key_name(user)] has aimed the bluespace artillery strike at [target].")
/obj/machinery/computer/bsa_control/proc/get_target_name()
Expand Down
9 changes: 5 additions & 4 deletions modular_nova/modules/bsa_overhaul/code/bsa_cannon.dm
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@
priority_announce("BLUESPACE TARGETING PARAMETERS SET, PREIGNITION STARTING... CAPACITOR CHARGE AT [round(capacitor_power / 1000000, 0.1)] MW, FIRING IN T-20 SECONDS!", "BLUESPACE ARTILLERY", ANNOUNCER_BLUESPACEARTY)
alert_sound_to_playing('modular_nova/modules/bsa_overhaul/sound/superlaser_prefire.ogg', override_volume = TRUE)
message_admins("[user] has started the fire cycle of [src]! Firing at: [ADMIN_VERBOSEJMP(bullseye)]")
log_game("[key_name(user)] has aimed the bluespace artillery strike at [bullseye].")
set_light(5, 5, COLOR_BLUE_LIGHT)
addtimer(CALLBACK(src, PROC_REF(fire), user, bullseye), 20 SECONDS, TIMER_CLIENT_TIME)

Expand Down Expand Up @@ -314,15 +315,15 @@
new /obj/effect/temp_visual/bsa_splash(point, dir)

if(!blocker)
message_admins("[ADMIN_LOOKUPFLW(user)] has launched an artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)].")
log_game("[key_name(user)] has launched an artillery strike targeting [AREACOORD(bullseye)].")
message_admins("[ADMIN_LOOKUPFLW(user)] has launched a bluespace artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)].")
user.log_message("has launched a bluespace artillery strike targeting [AREACOORD(bullseye)].", LOG_GAME)
minor_announce("BLUESPACE ARTILLERY FIRE SUCCESSFUL! DIRECT HIT!", "BLUESPACE ARTILLERY", TRUE)
create_calculated_explosion(bullseye)
alert_sound_to_playing('modular_nova/modules/bsa_overhaul/sound/superlaser_firing.ogg', override_volume = TRUE)
capacitor_power = 0
else
message_admins("[ADMIN_LOOKUPFLW(user)] has launched an artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)] but it was blocked by [blocker] at [ADMIN_VERBOSEJMP(target)].")
log_game("[key_name(user)] has launched an artillery strike targeting [AREACOORD(bullseye)] but it was blocked by [blocker] at [AREACOORD(target)].")
message_admins("[ADMIN_LOOKUPFLW(user)] has launched a bluespace artillery strike targeting [ADMIN_VERBOSEJMP(bullseye)] but it was blocked by [blocker] at [ADMIN_VERBOSEJMP(target)].")
user.log_message("has launched a bluespace artillery strike targeting [AREACOORD(bullseye)] but it was blocked by [blocker] at [AREACOORD(target)].", LOG_GAME)
minor_announce("BLUESPACE ARTILLERY MALFUNCTION!", "BLUESPACE ARTILLERY", TRUE)

/// Reloads the BSA.
Expand Down

0 comments on commit 55d9ecf

Please sign in to comment.