[MIRROR] Deletes unused hydroponics code [MDB IGNORE] (#25480)

* Deletes unused hydroponics code (#80156)

## About The Pull Request

`/obj/item/seeds/sample` was completely unused, ever since it's
inception in #16082
(tgstation/tgstation@d513f52)
as far as I can tell

(Me when "adds plant samples for future use" never makes use of them in
the future)

All this does is complicate hydro code so it dies.
Anything it is doing should be handled by genes probably

While I was here I made sure nothing in `can_add` will break and touched
up the code a tiny tiny bit. I kept it as `SHOULD_CALL_PARENT` even
though it doesn't make use of it at the moment because every trait
currently calls parent / respects return value, so sure, why not

## Changelog

Not necessary

* Deletes unused hydroponics code

---------

Co-authored-by: MrMelbert <[email protected]>

code/modules/hydroponics/hydroponics.dm

@@ -900,7 +900,7 @@
 			reagent_source.update_appearance()
 		return 1
 
-	else if(istype(O, /obj/item/seeds) && !istype(O, /obj/item/seeds/sample))
+	else if(istype(O, /obj/item/seeds))
 		if(!myseed)
 			if(istype(O, /obj/item/seeds/kudzu))
 				investigate_log("had Kudzu planted in it by [key_name(user)] at [AREACOORD(src)].", INVESTIGATE_BOTANY)

code/modules/hydroponics/plant_genes.dm

@@ -23,7 +23,8 @@
  * Returns TRUE if the seed can take the gene, and FALSE otherwise.
  */
 /datum/plant_gene/proc/can_add(obj/item/seeds/our_seed)
-	return !istype(our_seed, /obj/item/seeds/sample) // Samples can't accept new genes.
+	SHOULD_CALL_PARENT(TRUE)
+	return TRUE
 
 /// Copies over vars and information about our current gene to a new gene and returns the new instance of gene.
 /datum/plant_gene/proc/Copy()
@@ -151,9 +152,8 @@
 	if(!.)
 		return FALSE
 
-	for(var/obj/item/seeds/found_seed as anything in seed_blacklist)
-		if(istype(source_seed, found_seed))
-			return FALSE
+	if(is_type_in_list(source_seed, seed_blacklist))
+		return FALSE
 
 	for(var/datum/plant_gene/trait/trait in source_seed.genes)
 		if(trait_ids & trait.trait_ids)

code/modules/unit_tests/plantgrowth_tests.dm

@@ -3,7 +3,7 @@
 // Maybe some day it would be used as unit test.
 // -------- IT IS NOW!
 /datum/unit_test/plantgrowth/Run()
-	var/list/paths = subtypesof(/obj/item/seeds) - /obj/item/seeds - typesof(/obj/item/seeds/sample) - /obj/item/seeds/lavaland
+	var/list/paths = subtypesof(/obj/item/seeds) - /obj/item/seeds - /obj/item/seeds/lavaland
 
 	for(var/seedpath in paths)
 		var/obj/item/seeds/seed = new seedpath

tgstation.dme

@@ -4120,7 +4120,6 @@
 #include "code\modules\hydroponics\hydroponics.dm"
 #include "code\modules\hydroponics\hydroponics_chemreact.dm"
 #include "code\modules\hydroponics\plant_genes.dm"
-#include "code\modules\hydroponics\sample.dm"
 #include "code\modules\hydroponics\seed_extractor.dm"
 #include "code\modules\hydroponics\seeds.dm"
 #include "code\modules\hydroponics\unique_plant_genes.dm"