Skip to content

Commit

Permalink
[MIRROR] Disposal bins can now hold a destination tagger, and adds a …
Browse files Browse the repository at this point in the history
…few throughout maps. (#1506) (#2467)

* Disposal bins can now hold a destination tagger, and adds a few throughout maps. (#81991)

## About The Pull Request

![image](https://github.com/tgstation/tgstation/assets/41715314/5af9517f-ef5f-4284-aa87-bbf17170570e)
_Pictured, a disposal bin with a mounted destination tagger._

Disposal bins now have a dedicated mount where they can hold a
destination tagger, allowing for crewmates to more easily send items
through disposals to other departments. This can be especially useful
when on larger maps, or when cooperating on larger maps with remote
resources like on viro/xenobio.

All disposal bins can hold a destination tagger, but select ones on maps
have one pre-loaded.
Disposal bins can be removed with an empty hand and right click, and
re-attached with right click as well.

## Why It's Good For The Game

This helps assist with crew cooperation on maps where remote or
otherwise inaccessible departments have to really work to cooperate and
send resources, this chips away at the barrier of entry by giving most
departments a way to send resources back and forth as necessary through
the disposals network. It ALSO allows for additional opportunities for
players to send dangerous items like bombs or grenades through disposals
using destination taggers indirectly 👍

## Changelog

:cl:
add: Disposal bins can now hold destination taggers using right click,
and can be removed the same way. Some disposal bins should have some
pre-loaded as well.
/:cl:

---------




* Disposal bins can now hold a destination tagger, and adds a few throughout maps.

* Adds tagger icon state

pending inspection in game to see if it looks ok or needs editing

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: ArcaneMusic <[email protected]>
Co-authored-by: san7890 <[email protected]>
Co-authored-by: Jordan Dominion <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
  • Loading branch information
6 people authored Mar 20, 2024
1 parent c023714 commit 5ee412c
Show file tree
Hide file tree
Showing 9 changed files with 106 additions and 51 deletions.
15 changes: 6 additions & 9 deletions _maps/map_files/Birdshot/birdshot.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1466,8 +1466,8 @@
dir = 1
},
/obj/effect/turf_decal/tile/neutral/fourcorners,
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/smooth,
/area/station/command/bridge)
"aEl" = (
Expand Down Expand Up @@ -11922,7 +11922,6 @@
/obj/structure/disposalpipe/trunk{
dir = 4
},
/obj/machinery/disposal/bin,
/obj/structure/railing{
dir = 10
},
Expand All @@ -11931,6 +11930,7 @@
dir = 10
},
/obj/effect/decal/cleanable/dirt,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/plating,
/area/station/engineering/break_room)
"ewi" = (
Expand Down Expand Up @@ -24768,9 +24768,9 @@
/area/station/construction/mining/aux_base)
"iUN" = (
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/machinery/airalarm/directional/north,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/cargo/storage)
"iVq" = (
Expand Down Expand Up @@ -57444,8 +57444,8 @@
/obj/structure/disposalpipe/trunk{
dir = 8
},
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/white/side{
dir = 4
},
Expand Down Expand Up @@ -63482,10 +63482,7 @@
dir = 8
},
/obj/effect/turf_decal/stripes/box,
/obj/machinery/disposal/bin{
desc = "A pneumatic waste disposal unit. This one leads to the morgue.";
name = "corpse disposal"
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/dark,
/area/station/medical/medbay/central)
"vLT" = (
Expand Down Expand Up @@ -65241,8 +65238,8 @@
/obj/structure/disposalpipe/trunk{
dir = 8
},
/obj/machinery/disposal/bin,
/obj/structure/sign/poster/official/random/directional/north,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/dark,
/area/station/security/office)
"woT" = (
Expand Down
19 changes: 8 additions & 11 deletions _maps/map_files/Deltastation/DeltaStation2.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -7668,7 +7668,6 @@
/area/station/maintenance/port)
"bRw" = (
/obj/structure/sign/warning/deathsposal/directional/east,
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk{
dir = 8
},
Expand All @@ -7680,6 +7679,7 @@
/obj/effect/turf_decal/tile/purple/half/contrasted{
dir = 8
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/science/xenobiology)
"bRy" = (
Expand Down Expand Up @@ -17953,7 +17953,7 @@
},
/obj/effect/decal/cleanable/dirt,
/obj/effect/turf_decal/bot,
/obj/machinery/disposal/bin,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/engineering/storage)
"eua" = (
Expand Down Expand Up @@ -22028,7 +22028,6 @@
dir = 1
},
/obj/machinery/status_display/evac/directional/south,
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/structure/sign/directions/arrival{
dir = 1;
Expand All @@ -22038,6 +22037,7 @@
/obj/effect/turf_decal/tile/neutral{
dir = 4
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/hallway/secondary/entry)
"fux" = (
Expand Down Expand Up @@ -27315,7 +27315,6 @@
/turf/open/floor/plating,
/area/station/maintenance/department/engine/atmos)
"gIa" = (
/obj/machinery/disposal/bin,
/obj/machinery/light/small/directional/north,
/obj/structure/disposalpipe/trunk{
dir = 8
Expand All @@ -27324,6 +27323,7 @@
/obj/effect/turf_decal/tile/neutral{
dir = 4
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/security/brig)
"gIc" = (
Expand Down Expand Up @@ -38976,7 +38976,6 @@
/turf/open/floor/iron/dark,
/area/station/engineering/transit_tube)
"jFa" = (
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/machinery/status_display/evac/directional/west,
/obj/effect/turf_decal/siding/purple{
Expand All @@ -38986,6 +38985,7 @@
dir = 4
},
/obj/machinery/light/directional/west,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/science/lab)
"jFb" = (
Expand Down Expand Up @@ -51497,16 +51497,13 @@
/turf/open/floor/iron,
/area/station/medical/virology)
"mNL" = (
/obj/machinery/disposal/bin{
desc = "A pneumatic waste disposal unit. This one leads to the morgue.";
name = "corpse disposal"
},
/obj/effect/turf_decal/bot,
/obj/structure/disposalpipe/trunk{
dir = 8
},
/obj/effect/turf_decal/tile/blue/fourcorners,
/obj/machinery/light/directional/east,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/medical/medbay)
"mNX" = (
Expand Down Expand Up @@ -60185,7 +60182,6 @@
},
/area/station/commons/fitness/recreation)
"pen" = (
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/structure/disposalpipe/trunk{
dir = 1
Expand All @@ -60194,6 +60190,7 @@
/obj/effect/turf_decal/tile/neutral/anticorner/contrasted{
dir = 1
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/science/xenobiology)
"peo" = (
Expand Down Expand Up @@ -70546,7 +70543,6 @@
/turf/open/floor/iron,
/area/station/engineering/atmos/storage)
"rFV" = (
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/structure/disposalpipe/trunk,
/obj/machinery/camera/directional/north{
Expand All @@ -70556,6 +70552,7 @@
/obj/machinery/airalarm/directional/north,
/obj/effect/turf_decal/tile/neutral/fourcorners,
/obj/machinery/light/directional/north,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/dark,
/area/station/security/office)
"rFZ" = (
Expand Down
10 changes: 5 additions & 5 deletions _maps/map_files/IceBoxStation/IceBoxStation.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -11419,8 +11419,8 @@
/turf/open/floor/iron,
/area/station/commons/storage/mining)
"drG" = (
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/cargo/office)
"drH" = (
Expand Down Expand Up @@ -19051,8 +19051,8 @@
/area/station/science/explab)
"fOR" = (
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin,
/obj/machinery/airalarm/directional/east,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/white/side{
dir = 9
},
Expand Down Expand Up @@ -60422,9 +60422,9 @@
/obj/structure/disposalpipe/trunk{
dir = 1
},
/obj/machinery/disposal/bin,
/obj/machinery/computer/security/telescreen/entertainment/directional/south,
/obj/machinery/light/small/directional/east,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/dark,
/area/station/engineering/storage)
"sto" = (
Expand Down Expand Up @@ -61433,7 +61433,7 @@
dir = 5
},
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/white,
/area/station/medical/medbay/aft)
"sHh" = (
Expand Down Expand Up @@ -74208,8 +74208,8 @@
/turf/open/floor/plating,
/area/station/maintenance/port/aft)
"wMV" = (
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/dark/textured_half{
dir = 1
},
Expand Down
12 changes: 6 additions & 6 deletions _maps/map_files/MetaStation/MetaStation.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1389,10 +1389,10 @@
/turf/open/floor/plating,
/area/station/engineering/supermatter/room)
"aBJ" = (
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/delivery,
/obj/effect/turf_decal/siding,
/obj/structure/disposalpipe/trunk,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/science/lab)
"aBL" = (
Expand Down Expand Up @@ -3254,13 +3254,13 @@
network = list("ss13","medbay")
},
/obj/item/radio/intercom/directional/west,
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk{
dir = 4
},
/obj/effect/turf_decal/tile/blue/anticorner/contrasted{
dir = 1
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron/white,
/area/station/medical/medbay/central)
"bgV" = (
Expand Down Expand Up @@ -6857,7 +6857,6 @@
/turf/open/space,
/area/space/nearstation)
"cxq" = (
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk{
dir = 1
},
Expand All @@ -6869,6 +6868,7 @@
name = "Labor Camp Shuttle Lockdown";
req_access = list("brig")
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/security/brig)
"cxt" = (
Expand Down Expand Up @@ -9560,7 +9560,6 @@
/turf/open/floor/iron,
/area/station/science/research)
"dBv" = (
/obj/machinery/disposal/bin,
/obj/machinery/airalarm/directional/east,
/obj/structure/disposalpipe/trunk{
dir = 1
Expand All @@ -9569,6 +9568,7 @@
dir = 8
},
/obj/machinery/light/small/directional/east,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/cargo/storage)
"dBV" = (
Expand Down Expand Up @@ -43748,11 +43748,11 @@
/turf/open/floor/iron,
/area/station/engineering/atmos/storage/gas)
"pIz" = (
/obj/machinery/disposal/bin,
/obj/effect/turf_decal/bot,
/obj/structure/disposalpipe/trunk{
dir = 8
},
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/wood,
/area/station/commons/lounge)
"pID" = (
Expand Down Expand Up @@ -59399,11 +59399,11 @@
/turf/open/floor/iron/dark,
/area/station/security/courtroom)
"vfO" = (
/obj/machinery/disposal/bin,
/obj/structure/disposalpipe/trunk{
dir = 8
},
/obj/effect/turf_decal/tile/yellow/half/contrasted,
/obj/machinery/disposal/bin/tagger,
/turf/open/floor/iron,
/area/station/engineering/break_room)
"vfU" = (
Expand Down
Loading

0 comments on commit 5ee412c

Please sign in to comment.