Skip to content

Commit

Permalink
Cleans up a lot of old gun stuff, and either adds or tweaks some crat…
Browse files Browse the repository at this point in the history
…es in preparation for some stuff i want to do later (#689)

* sweeps up a bit

* oh yeah baby

* whoops!

* fixes the surplus box

* yknow i fucked up

* Update modular_nova/modules/modular_weapons/code/cargo_crates/surplus_crates.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_weapons/code/cargo_crates/surplus_crates.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/modular_weapons/code/cargo_crates/surplus_crates.dm

Co-authored-by: Bloop <[email protected]>

* Update surplus_crates.dm

---------

Co-authored-by: Bloop <[email protected]>
  • Loading branch information
2 people authored and FFMirrorBot committed Feb 9, 2024
1 parent 5f916e8 commit 6eb1f0f
Show file tree
Hide file tree
Showing 14 changed files with 180 additions and 210 deletions.
4 changes: 0 additions & 4 deletions code/modules/cargo/packs/imports.dm
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,6 @@
/obj/item/grenade/mirage = 5,
)

// NOVA EDIT REMOVAL BEGIN - REPLACED BY LORE BEFITTING CRATE AT: modular_nova/modules/cargo/code/packs.dm
/*
/datum/supply_pack/imports/russian
name = "Russian Surplus Military Gear Crate"
desc = "Hello <;~insert appropriate greeting here: 'Comrade'|'Imperalist Scum'|'Quartermaster of Reputable Station'~;>, \
Expand Down Expand Up @@ -238,8 +236,6 @@
for(var/items in 1 to 10)
var/item = pick(contains)
new item(our_crate)
*/
// NOVA EDIT REMOVAL END

/datum/supply_pack/imports/moistnuggets
name = "Refurbished Sakhno Precision Rifle Crate"
Expand Down
28 changes: 0 additions & 28 deletions modular_nova/modules/cargo/code/packs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -711,34 +711,6 @@
for(var/i in 1 to 19)
new /obj/item/grown/log(.)

/datum/supply_pack/imports/cin_surplus
name = "CIN Military Surplus Crate"
desc = "A collection of surplus equipment sourced from the Coalition of Independent Nations' military stockpiles. Likely to contain old and outdated equipment, as is the nature of surplus."
contraband = TRUE
cost = CARGO_CRATE_VALUE * 9
contains = list(
/obj/item/storage/box/colonial_rations = 1,
/obj/item/storage/toolbox/ammobox/strilka310 = 1,
/obj/item/storage/toolbox/ammobox/strilka310/surplus = 1,
/obj/item/storage/toolbox/maint_kit = 1,
/obj/item/storage/toolbox/guncase/soviet/sakhno = 2,
/obj/item/ammo_box/strilka310 = 1,
/obj/item/clothing/suit/armor/vest/cin_surplus_vest = 1,
/obj/item/clothing/head/helmet/cin_surplus_helmet/random_color = 1,
/obj/item/storage/backpack/industrial/cin_surplus/random_color = 1,
/obj/item/storage/belt/military/cin_surplus/random_color = 1,
/obj/item/clothing/gloves/tackler/combat = 1,
/obj/item/clothing/under/syndicate/rus_army/cin_surplus/random_color = 1,
/obj/item/clothing/shoes/jackboots = 1,
/obj/item/clothing/mask/gas/hecu2 = 1,
/obj/item/clothing/mask/balaclavaadjust = 1,
)

/datum/supply_pack/imports/cin_surplus/fill(obj/structure/closet/crate/we_are_filling_this_crate)
for(var/i in 1 to 10)
var/item = pick_weight(contains)
new item(we_are_filling_this_crate)

/*
* VENDING RESTOCKS
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
item_type = /obj/item/storage/backpack/industrial/cin_surplus/random_color
cost = PAYCHECK_CREW

/datum/armament_entry/company_import/nri_surplus/clothing/gas_mask
item_type = /obj/item/clothing/mask/gas/hecu2
cost = PAYCHECK_CREW

/datum/armament_entry/company_import/nri_surplus/clothing/helmet
item_type = /obj/item/clothing/head/helmet/cin_surplus_helmet/random_color
cost = PAYCHECK_COMMAND
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
/obj/item/ammo_box/c46x30mm/rubber
name = "ammo box (4.6x30mm rubber)"
ammo_type = /obj/item/ammo_casing/c46x30mm/rubber
<<<<<<< HEAD

Check failure on line 57 in modular_nova/modules/company_imports/code/objects/vitezstvi/ammo_boxes.dm

View workflow job for this annotation

GitHub Actions / Run Linters

got '<<', expected one of: newline, '/', identifier

/obj/item/ammo_box/c34
name = "ammo box (.34)"
Expand Down Expand Up @@ -82,3 +83,5 @@
new /obj/item/stock_parts/cell/microfusion/bluespace(src)
new /obj/item/stock_parts/cell/microfusion/bluespace(src)
new /obj/item/stock_parts/cell/microfusion/bluespace(src)
=======
>>>>>>> e1b64e887 (Cleans up a lot of old gun stuff, and either adds or tweaks some crates in preparation for some stuff i want to do later (#689))
99 changes: 0 additions & 99 deletions modular_nova/modules/modular_weapons/code/autolathe_designs.dm

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/datum/supply_pack/security/armory/sindano
name = "Sindano Submachinegun Crate"
desc = "Three entirely proprietary Sindano kits, chambered in .35 Sol Short. Each kit contains three empty magazines and a box each of incapacitator and lethal rounds."
cost = CARGO_CRATE_VALUE * 10
contains = list(
/obj/item/storage/toolbox/guncase/nova/carwo_large_case/sindano = 3,
)
<<<<<<< HEAD:modular_nova/modules/sec_haul/code/guns/cargo_stuff.dm
crate_name = "Carwo 'Sindano' Submachinegun Crate"
=======
crate_name = "Sindano Submachinegun Crate"

/datum/supply_pack/security/armory/renoster
name = "Renoster Riot Shotgun Crate"
desc = "Three Renoster 12ga riot shotguns, with matching bandoliers for each."
cost = CARGO_CRATE_VALUE * 10
contains = list(
/obj/item/gun/ballistic/shotgun/riot/sol = 3,
/obj/item/storage/belt/bandolier = 3,
)
crate_name = "Renoster Riot Shotgun Crate"

/datum/supply_pack/security/armory/kiboko
name = "Kiboko Grenade Launcher Crate"
desc = "Contains a single Kiboko grenade launcher for replacing the one found in the armory, alongside the equipment that comes with it."
cost = CARGO_CRATE_VALUE * 30
contains = list(
/obj/item/storage/toolbox/guncase/nova/carwo_large_case/kiboko_magless = 1,
/obj/item/ammo_box/c980grenade = 2,
/obj/item/ammo_box/c980grenade/smoke = 1,
/obj/item/ammo_box/c980grenade/riot = 1,
)
crate_name = "Kiboko Grenade Launcher Crate"

/datum/supply_pack/security/armory/short_mod_laser
name = "Modular Laser Carbine Crate"
desc = "Five 'Hoshi' modular laser carbines, compact energy weapons that can be rapidly reconfigured into different firing modes."
cost = CARGO_CRATE_VALUE * 12
contains = list(
/obj/item/gun/energy/modular_laser_rifle/carbine,
/obj/item/gun/energy/modular_laser_rifle/carbine,
/obj/item/gun/energy/modular_laser_rifle/carbine,
/obj/item/gun/energy/modular_laser_rifle/carbine,
/obj/item/gun/energy/modular_laser_rifle/carbine,
)
crate_name = "\improper Modular Laser Carbine Crate"

/datum/supply_pack/security/armory/big_mod_laser
name = "Modular Laser Rifle Crate"
desc = "Three 'Hyeseong' modular laser rifles, bulky energy weapons that can be rapidly reconfigured into different firing modes."
cost = CARGO_CRATE_VALUE * 12
contains = list(
/obj/item/gun/energy/modular_laser_rifle,
/obj/item/gun/energy/modular_laser_rifle,
/obj/item/gun/energy/modular_laser_rifle,
)
crate_name = "\improper Modular Laser Rifle Crate"
>>>>>>> e1b64e887 (Cleans up a lot of old gun stuff, and either adds or tweaks some crates in preparation for some stuff i want to do later (#689)):modular_nova/modules/modular_weapons/code/cargo_crates/armory_guns.dm
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
#define ITEM_WEIGHT_CLOTHING 3
#define ITEM_WEIGHT_ARMOR 2
#define ITEM_WEIGHT_MISC 3
#define ITEM_WEIGHT_MISC_BUT_RARER 2
#define ITEM_WEIGHT_AMMO_SINGLE 3
#define ITEM_WEIGHT_AMMO_BULK 2
#define ITEM_WEIGHT_GUN_COMMON 2
#define ITEM_WEIGHT_GUN_RARE 1


// used in budget calculation
#define CRATE_ITEM_WEIGHT_MAX 3

#define CRATE_BUDGET_MINIMUM 20
#define CRATE_BUDGET_MAXIMUM 35

// Special basically locks it out of appearing literally ever unless an admin VV's the cargo subsystem
/datum/supply_pack/imports/russian
special = TRUE

/datum/supply_pack/imports/cin_surplus
name = "CIN Surplus Equipment Crate"
desc = "A collection of surplus equipment sourced from the Coalition of Independent Nations' military stockpiles. Likely to contain old and outdated equipment, as is the nature of surplus."
contraband = TRUE
cost = CARGO_CRATE_VALUE * 20
contains = list(
// Clothing
/obj/item/clothing/under/syndicate/rus_army/cin_surplus/random_color = ITEM_WEIGHT_CLOTHING,
/obj/item/storage/belt/military/cin_surplus/random_color = ITEM_WEIGHT_CLOTHING,
/obj/item/storage/backpack/industrial/cin_surplus/random_color = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/under/colonial/nri_police = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/neck/cloak/colonial/nri_police = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/head/hats/colonial/nri_police = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/mask/gas/nri_police = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/mask/balaclavaadjust = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/gloves/tackler/combat = ITEM_WEIGHT_CLOTHING,
/obj/item/clothing/shoes/jackboots = ITEM_WEIGHT_CLOTHING,
// Armors
/obj/item/clothing/head/helmet/cin_surplus_helmet/random_color = ITEM_WEIGHT_ARMOR,
/obj/item/clothing/suit/armor/vest/cin_surplus_vest = ITEM_WEIGHT_ARMOR,
/obj/item/clothing/head/helmet/nri_police = ITEM_WEIGHT_ARMOR,
/obj/item/clothing/suit/armor/vest/nri_police = ITEM_WEIGHT_ARMOR,
// Weapons
/obj/item/gun/ballistic/revolver/shotgun_revolver = ITEM_WEIGHT_GUN_COMMON,
/obj/item/gun/ballistic/automatic/pistol/plasma_thrower = ITEM_WEIGHT_GUN_COMMON,
/obj/item/gun/ballistic/automatic/pistol/plasma_marksman = ITEM_WEIGHT_GUN_COMMON,
/obj/item/storage/toolbox/guncase/soviet/sakhno = ITEM_WEIGHT_GUN_COMMON,
/obj/item/gun/ballistic/automatic/miecz = ITEM_WEIGHT_GUN_RARE,
/obj/item/gun/ballistic/automatic/lanca = ITEM_WEIGHT_GUN_RARE,
/obj/item/gun/ballistic/automatic/wylom = ITEM_WEIGHT_GUN_RARE,
// Ammo
/obj/item/storage/toolbox/ammobox/strilka310 = ITEM_WEIGHT_AMMO_BULK,
/obj/item/storage/toolbox/ammobox/strilka310/surplus = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/c27_54cesarzowa = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/c27_54cesarzowa/rubber = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/c310_cargo_box = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/c310_cargo_box/rubber = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/c310_cargo_box/piercing = ITEM_WEIGHT_AMMO_BULK,
/obj/item/ammo_box/magazine/recharge/plasma_battery = ITEM_WEIGHT_AMMO_SINGLE,
/obj/item/ammo_box/magazine/miecz/spawns_empty = ITEM_WEIGHT_AMMO_SINGLE,
/obj/item/ammo_box/strilka310 = ITEM_WEIGHT_AMMO_SINGLE,
/obj/item/ammo_box/magazine/lanca/spawns_empty = ITEM_WEIGHT_AMMO_SINGLE,
/obj/item/ammo_box/magazine/wylom = ITEM_WEIGHT_AMMO_SINGLE,
// Other items
/obj/item/sign/flag/nri = ITEM_WEIGHT_MISC,
/obj/item/trench_tool = ITEM_WEIGHT_MISC,
/obj/item/binoculars = ITEM_WEIGHT_MISC,
/obj/item/storage/box/nri_flares = ITEM_WEIGHT_MISC,
/obj/item/pen/screwdriver = ITEM_WEIGHT_MISC_BUT_RARER,
/obj/item/storage/box/colonial_rations = ITEM_WEIGHT_MISC_BUT_RARER,
/obj/item/storage/toolbox/maint_kit = ITEM_WEIGHT_MISC_BUT_RARER,
)

/datum/supply_pack/imports/cin_surplus/fill(obj/structure/closet/crate/we_are_filling_this_crate)
var/item_budget = rand(CRATE_BUDGET_MINIMUM, CRATE_BUDGET_MAXIMUM)
for(var/iterator in 1 to 20) // 20 items max, but we have a budget too
var/new_thing = pick_weight(contains)
// We don't want to go too far over budget
if(item_budget <= 0)
return
new new_thing(we_are_filling_this_crate)
// Basically inverts the weight before subtracting it from the budget
item_budget -= ((CRATE_ITEM_WEIGHT_MAX + 1) - contains[new_thing])

#undef ITEM_WEIGHT_CLOTHING
#undef ITEM_WEIGHT_ARMOR
#undef ITEM_WEIGHT_MISC
#undef ITEM_WEIGHT_MISC_BUT_RARER
#undef ITEM_WEIGHT_AMMO_SINGLE
#undef ITEM_WEIGHT_AMMO_BULK
#undef ITEM_WEIGHT_GUN_COMMON
#undef ITEM_WEIGHT_GUN_RARE

#undef CRATE_ITEM_WEIGHT_MAX

#undef CRATE_BUDGET_MINIMUM
#undef CRATE_BUDGET_MAXIMUM
60 changes: 0 additions & 60 deletions modular_nova/modules/modular_weapons/code/modular_projectiles.dm
Original file line number Diff line number Diff line change
Expand Up @@ -107,63 +107,3 @@
/obj/projectile/bullet/a223/ap
name = ".277 armor-piercing bullet"
armour_penetration = 60

/*
* .34 ACP
*/

// Why? Blame CFA, they want their bullets to be *proprietary*
/obj/item/ammo_casing/c34
name = ".34 bullet casing"
desc = "A .34 bullet casing."
caliber = "c34acp"
projectile_type = /obj/projectile/bullet/c34

/obj/projectile/bullet/c34
name = ".34 bullet"
damage = 15
wound_bonus = 0

/obj/item/ammo_casing/c34/rubber
name = ".34 rubber bullet casing"
desc = "A .34 rubber bullet casing."
caliber = "c34acp"
projectile_type = /obj/projectile/bullet/c34/rubber
harmful = FALSE

/obj/projectile/bullet/c34/rubber
name = ".34 rubber bullet"
damage = 5
stamina = 20
wound_bonus = -75
shrapnel_type = null
sharpness = NONE
embedding = null

/obj/item/ammo_casing/c34/ap
name = ".34 armor-piercing bullet casing"
desc = "A .34 armor-piercing bullet casing."
caliber = "c34acp"
projectile_type = /obj/projectile/bullet/c34/ap
custom_materials = AMMO_MATS_AP
advanced_print_req = TRUE

/obj/projectile/bullet/c34/ap
name = ".34 armor-piercing bullet"
damage = 15
armour_penetration = 40
wound_bonus = -75

/obj/item/ammo_casing/c34_incendiary
name = ".34 incendiary bullet casing"
desc = "A .34 incendiary bullet casing."
caliber = "c34acp"
projectile_type = /obj/projectile/bullet/incendiary/c34_incendiary
custom_materials = AMMO_MATS_TEMP
advanced_print_req = TRUE

/obj/projectile/bullet/incendiary/c34_incendiary
name = ".34 incendiary bullet"
damage = 8
fire_stacks = 1
wound_bonus = -90
Loading

0 comments on commit 6eb1f0f

Please sign in to comment.