Skip to content

Commit

Permalink
[MIRROR] Update lead acid batteries charge values (#1878)
Browse files Browse the repository at this point in the history
* Update lead acid batteries charge values (#82510)

## About The Pull Request

So during the whole power consistency update thing, it seems lead acid
batteries were entirely forgotten about.
Which, well, is easy, because they never actually used
`STANDARD_CELL_CHARGE`.

https://github.com/tgstation/tgstation/blob/c34d56a45b0461f5e0fad3cc75e81580c3357119/code/game/objects/items/maintenance_loot.dm#L32-L33
Looking into it, the previous value for `STANDARD_CELL_CHARGE` seemed to
have been 1000, so we convert it directly:
```dm
maxcharge = STANDARD_CELL_CHARGE * 20
chargerate = STANDARD_CELL_CHARGE * 1.4
```
But, comparing this to the normal power cells, it seems their charge
rates got _halved_ during the update.
So, we do that too.
```dm
maxcharge = STANDARD_CELL_CHARGE * 20
chargerate = STANDARD_CELL_CHARGE * 0.7
```
And that fixes it.
## Why It's Good For The Game

Fixes lead acid batteries still using the old power amounts, and not
being relative to `STANDARD_CELL_CHARGE`.
## Changelog
:cl:
fix: Lead acid batteries have had their power values fixed.
/:cl:

* Update lead acid batteries charge values

---------

Co-authored-by: _0Steven <[email protected]>
  • Loading branch information
2 people authored and StealsThePRs committed Apr 9, 2024
1 parent 002019a commit 79157b9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions code/game/objects/items/maintenance_loot.dm
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
icon = 'icons/obj/maintenance_loot.dmi'
icon_state = "lead_battery"
throwforce = 10
maxcharge = 20000 //decent max charge
chargerate = 1400 //charging is about 30% less efficient than lithium batteries.
maxcharge = STANDARD_CELL_CHARGE * 20 //decent max charge
chargerate = STANDARD_CELL_CHARGE * 0.7 //charging is about 30% less efficient than lithium batteries.
charge_light_type = null
connector_type = "leadacid"
rating = 2 //Kind of a mid-tier battery
Expand Down

0 comments on commit 79157b9

Please sign in to comment.