[MIRROR] [NO GBP] Fixes spurious runtime caused by icemoon (again) (#…

…2842) * [NO GBP] Fixes spurious runtime caused by icemoon (again) (#82582) tgstation/tgstation#82572 I tried to fix this but there was an unaccounted race condition which just caused a separate runtime... ![firefox_GxGibAO281](https://github.com/tgstation/tgstation/assets/13398309/f251aecc-ef17-4bae-a741-5aade40de423) Since the type is being changed mid-execution `replacement_turf` will become out of scope. My bad--this should fix it now for good. * [NO GBP] Fixes spurious runtime caused by icemoon (again) --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Bloop <[email protected]> Co-authored-by: Iajret <[email protected]>
Fluffy-Frontier · Apr 12, 2024 · ce60a06 · ce60a06
1 parent 330c55c
commit ce60a06
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/code/game/turfs/open/openspace.dm b/code/game/turfs/open/openspace.dm
@@ -187,8 +187,8 @@
 	if(!T)
 		return
 	if(T.turf_flags & NO_RUINS && protect_ruin)
-		ChangeTurf(replacement_turf, null, CHANGETURF_IGNORE_AIR)
-		if(!isopenspaceturf(replacement_turf)) // only openspace turfs should be returning INITIALIZE_HINT_LATELOAD
+		var/turf/newturf = ChangeTurf(replacement_turf, null, CHANGETURF_IGNORE_AIR)
+		if(!isopenspaceturf(newturf)) // only openspace turfs should be returning INITIALIZE_HINT_LATELOAD
 			return INITIALIZE_HINT_NORMAL
 		return
 	if(!ismineralturf(T) || !drill_below)