Skip to content

Commit

Permalink
[MIRROR] Reverts parts of #82602 (nodeath checks) (#2890)
Browse files Browse the repository at this point in the history
* Reverts parts of #82602 (nodeath checks) (#82637)

## About The Pull Request

Reverts the nodeath checks of #82602

I opened a review thinking these checks were sus and the PR author said
they would remove them, but it was merged before that happened.

TL;DR 

1. I just noticed this now but it only affects carbons / humans it
doesn't even cover living or any other subtypes
2. Kinda sus. Some code intentionally skips checking nodeath (I guess?
Like removing the brain for example) so we would need a larger audit of
this rather than haphazardly throwing it in.

* Reverts parts of #82602 (nodeath checks)

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
  • Loading branch information
3 people authored Apr 15, 2024
1 parent 7eccdef commit df24d40
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion code/modules/mob/living/carbon/death.dm
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/mob/living/carbon/death(gibbed)
if(stat == DEAD || HAS_TRAIT(src, TRAIT_NODEATH) && !gibbed)
if(stat == DEAD)
return

losebreath = 0
Expand Down
2 changes: 1 addition & 1 deletion code/modules/mob/living/carbon/human/death.dm
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GLOBAL_LIST_EMPTY(dead_players_during_shift)
new /obj/effect/decal/remains/human(loc)

/mob/living/carbon/human/death(gibbed)
if(stat == DEAD || HAS_TRAIT(src, TRAIT_NODEATH) && !gibbed)
if(stat == DEAD)
return
stop_sound_channel(CHANNEL_HEARTBEAT)
var/obj/item/organ/internal/heart/human_heart = get_organ_slot(ORGAN_SLOT_HEART)
Expand Down

0 comments on commit df24d40

Please sign in to comment.