Skip to content

Commit

Permalink
[MIRROR] Flightpotion/health analyzer balance tweak [MDB IGNORE] (#24…
Browse files Browse the repository at this point in the history
…856) (#503)

* Flightpotion/health analyzer balance tweak (#79396)

## About The Pull Request

I was asked by a maintainer to split this off from my other PR (#79360),
so here it is. Basically, health analyzers are hard-coded to list you as
a mutant if you have wings from a flightpotion. This only applies to
flightpotion wings; no other organ, internal or external, not even moth
wings, work in the same way. So this PR just removes that check for
consistency.

I'd also like to note that I'm not opposed to the flightpotion being
made to _actually_ change your species again, as long as someone else
does the work. In fact, if someone were to do that this change would
still make just as much if not more sense.
## Why It's Good For The Game

As far as I can tell, there is no reason for this check to exist. At one
point, the flight potion did actually change your species, and it seems
like this check is just an old, unneeded relic of that. I'm not aware
for any balance reason for this check, unlike the hulk mutation.
Although you can argue that policy lists people with angel wings as
being nonhuman, that is specifically because the health analyzer lists
them as mutants, so it makes no sense for health analyzers to do so
because of policy.
## Changelog
:cl:
balance: Flightpotion wings will no longer make health analyzers list
you as nonhuman.
/:cl:

* Flightpotion/health analyzer balance tweak

---------

Co-authored-by: SkyratBot <[email protected]>
Co-authored-by: GPeckman <[email protected]>
  • Loading branch information
3 people authored Nov 9, 2023
1 parent 9c2d2a1 commit dfb82d9
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions code/game/objects/items/devices/scanners/health_analyzer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -319,19 +319,9 @@
if(advanced && humantarget.has_dna())
render_list += "<span class='info ml-1'>Genetic Stability: [humantarget.dna.stability]%.</span>\n"

// Species and body temperature
// Hulk and body temperature
var/datum/species/targetspecies = humantarget.dna.species
var/mutant = humantarget.dna.check_mutation(/datum/mutation/human/hulk) \
|| targetspecies.mutantlungs != initial(targetspecies.mutantlungs) \
|| targetspecies.mutantbrain != initial(targetspecies.mutantbrain) \
|| targetspecies.mutantheart != initial(targetspecies.mutantheart) \
|| targetspecies.mutanteyes != initial(targetspecies.mutanteyes) \
|| targetspecies.mutantears != initial(targetspecies.mutantears) \
|| targetspecies.mutanttongue != initial(targetspecies.mutanttongue) \
|| targetspecies.mutantliver != initial(targetspecies.mutantliver) \
|| targetspecies.mutantstomach != initial(targetspecies.mutantstomach) \
|| targetspecies.mutantappendix != initial(targetspecies.mutantappendix) \
|| istype(humantarget.get_organ_slot(ORGAN_SLOT_EXTERNAL_WINGS), /obj/item/organ/external/wings/functional)
var/mutant = humantarget.dna.check_mutation(/datum/mutation/human/hulk)

render_list += "<span class='info ml-1'>Species: [targetspecies.name][mutant ? "-derived mutant" : ""]</span>\n"
var/core_temperature_message = "Core temperature: [round(humantarget.coretemperature-T0C, 0.1)] &deg;C ([round(humantarget.coretemperature*1.8-459.67,0.1)] &deg;F)"
Expand Down

0 comments on commit dfb82d9

Please sign in to comment.